Coder Social home page Coder Social logo

sismo-core / hydra-s1-zkps Goto Github PK

View Code? Open in Web Editor NEW
231.0 7.0 16.0 53.01 MB

Hydra-S1 ZK Proving scheme circuits, used for ZK Attesters in Sismo

Home Page: https://hydra-s1.docs.sismo.io

License: MIT License

Shell 3.42% TypeScript 74.77% Solidity 19.67% JavaScript 2.13%
circom snarkjs zk zk-snarks zkp

hydra-s1-zkps's People

Contributors

blakemscurr avatar davidcardenasus avatar gabin54 avatar leosayous21 avatar lissstern avatar nerdynomadd avatar yum0e avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

hydra-s1-zkps's Issues

No need for range check

The range check performed here on sourceValue and claimedValue is not necessary in my opinion.

This range check would only fail if:

  • 2 ** 252 <= sourceValue < p
  • 2 ** 252 <= claimedValue < p

And these are not actually cases of overflow.

I performed the test included in the library after having removed these 4 lines and they all pass successfully.

You can check these 2 gists here (circuit and test) to test out my hypotheses.

It would be interesting to understand if the LessOrEqual operation is sufficient to prevent any overflow

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.