sirnoob97 / dups

Duplicate file finder

About Me

Junior backend developer focused on DevOps culture, lover of self-taught learning and open source, especially the Linux universe.

---

Languages and Tools

---

My Trophies

---

Github Stats

dups's Issues

Concurrent Test

Tests must be refactored for the concurrent version of the application.

Changes:

• readTree function now receives a channel(paths) and a waitgroup(wg) as a parameter
  

  dups/main.go

  Line 34 in b91968d

  func readTree(directory string, paths chan string, wg *sync.WaitGroup) error {

---

• getHash function no longer returns errors.
  

  dups/main.go

  Line 70 in b91968d

  func getHash(path string) fileHash {

• getHash now shows errors with logFatal variable
  

  dups/main.go

  Lines 14 to 17 in b91968d

  	var (
  	logFatal = log.Fatal
  	ignore = []string{".git"}
  	)

  
  

  dups/main.go

  Lines 72 to 74 in b91968d

  	if err != nil {
  	logFatal(err)
  	}

  
  

  dups/main.go

  Lines 78 to 80 in b91968d

  	if _, err := io.Copy(hash, file); err != nil {
  	logFatal(err)
  	}

---

• new functions must have test cases
  

  dups/main.go

  Line 89 in b91968d

  func hashFile(paths chan string, fHash chan fileHash, done chan bool) {

  
  

  dups/main.go

  Line 97 in b91968d

  func run(directory string) md5Table {

Concurrent Refactor

Take advantage of the go concurrency features.

Complete TODOs

TODO list:

• dups/main.go

  Lines 28 to 29 in 3b8025e

  	// TODO: refactor this function, this function should only read a directory tree
  	// TODO: extract hash operations

• dups/main.go

  Line 51 in 3b8025e

  // TODO: implement a better error handling

Tests

The project needs basic testing before concurrent refactor.