sinytra / connectorextras Goto Github PK

Describe the bug

The ItemMixin from Reach Entity Attributes (Connector Extras implementation) seems to be causing an injection error when used with Spectrum in a development environment.

Steps to reproduce

1. Clone https://github.com/eehunter/Spectral-Dragons
2. Execute ./gradlew runClient

Logs

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Constant modifier method getActualReachDistance(DLnet/minecraft/world/level/Level;Lnet/minecraft/world/entity/player/Player;)D in mixins.reach-entity-attributes.json:ItemMixin from mod reach_entity_attributes failed injection check, (0/4) succeeded. Scanned 1 target(s). Using refmap refmap.reach-entity-attributes.json at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) at MC-BOOTSTRAP/org.spongepowered.mixin/org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)

Additional context

I'm attempting to make a compatibility addon for Spectrum (a Fabric-only mod) and Dragon Survival (a Forge-only mod). When Spectrum is added to the development environment, the above issue occurs. Dragon Survival has been temporarily disabled in the dev environment to help isolate the issue. I have spent 2+ hours trying to debug this will no success, and my knowledge of the inner workings of Mixin and Connector are not sufficient to properly diagnose this. I don't actually know if it's a bug in my buildscript or Connector Extras. I think the former is more likely, but I'm submitting this issue in case the latter is true.

Am unsure why but it makes uploading go under manual review and take longer.
Only applies to server files

Describe the bug

I can't see all recipes of modern industrialization that are made on top of custom crafting tables (for example the steel ingot is made by steel dust, but steel dust have no recipe

Steps to reproduce

1. Install the architectury mod for forge, cloth config api for forge, rei for forge and REIPluginCompatibilities for forge
2. Install modern industrialization for fabric
3. Try to see the recipe of the steel ingot
4. Notice that the steel ingot is made by steel dust, and the steel dust is made by steel tiny dust, but steel tiny dust is made by steel dust
5. Try to serach "bolt" in rei and try to see the recipe of any bolt, like the steel bolt

Logs

https://mclo.gs/L6YU9FD

Additional context

Of course if i try to load the mods with fabric without connector and with all mods for fabric it works

Describe the bug

Using Geckolib fabric or forge with Marium Soulslike Weaponry and Ars Nouveau Crashes during initialization.

Steps to reproduce

1. Compile & install newest branch of ConnectorExtras with the newest releases for connector; install the following mods:
   

2. Launch MC.

3. Experience crash during initialization.

Logs

https://pastebin.com/nh33zQV4

Additional context

Compiled the dev master branch for ConnectorExtras to get past a pehkui mixin error but got a different geckolib error during startup. Looking at other issues here, it seems other mods that can use geckolib fabric are present like Bosses of Mass Destruction but some cannot.

Describe the bug

Crashes on Server

Steps to reproduce

It is in combination with Connector 19 Build +Recent Connector Extras Build
I am aware that you might not be finished due to this not being the final release, however just in case it was an oversight ;P
Debug: https://pastebin.com/6pP6iTx5

Logs

https://pastebin.com/vQMXURnV

Additional context

No response

Describe the bug

Armor not modified with Tierify

Steps to reproduce

1.Install Connector Extras and its dependencies
2.Install Tierify and its dependences
3.Check any loot tables [ex ruin portal] and see armor not being modified
...

Logs

No response

Additional context

I believe its an issue with loot tables since all forks of Tiered have the same issue with armor but I may be wrong.

Describe the bug

Recipes for inside the machines are missing for techreborn

Steps to reproduce

1. Install mods
2. Place down a tech reborn grinder
3. Place a diamond inside watch it grind to diamond dust
4. View JEI Recipes for Diamond Dust
5. Notice recipe using the grinder is missing only the crafting one
   ...

Logs

N/A

Additional context

Connector-1.0.0-beta.19+1.20.1-full.jar
ConnectorExtras-1.4.1+1.20.1.jar
fabric-api-0.90.0+1.9.27+1.20.1.jar
TechReborn-5.8.7.jar
jei-1.20.1-forge-15.2.0.27.jar

Inside the machine

What JEI tell you

You can see recipes for crafting machines, but can't see recipes for crafting inside machines. Some reason only REI allows you too.

Describe the bug

I tried to download VS2 into a modpack using connector, but always crashes in startup with something to do with 'reach_entity_attributes' mixins

Steps to reproduce

1. Download Better MC
2. Add VS2 and any dependancies
3. disable ryoamic lights
4. attempt to launch game
   ...

Logs

https://mclo.gs/5T0Pw6e

Additional context

No response

Trinkets have some issues that work with Connector (like rendering, effective issues) and are also unnecessary.

Describe the bug

Everytime I join my server I get that error

Steps to reproduce

1.Anytime anyone join my server
at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:343) ~[server-1.20.1-20230612.114412-srg.jar%23331!/:?] {re:mixin,pl:accesstransformer:B,pl:connector_pre_launch:A,re:computing_frames,pl:accesstransformer:B,pl:connector_pre_launch:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:cupboard.mixins.json:ServerAddEntityMixin from mod cupboard,pl:mixin:APP:betterendisland.mixins.json:ServerLevelMixin from mod betterendisland,pl:mixin:APP:servercore.common.mixins.json:optimizations.ticking.chunk.random.ServerLevelMixin from mod servercore,pl:mixin:APP:citadel.mixins.json:ServerLevelMixin from mod citadel,pl:mixin:APP:mixins.cardinal_components_entity.json:common.MixinServerWorld from mod cardinal_components_entity,pl:mixin:APP:servercore.common.mixins.json:features.activation_range.ServerLevelMixin from mod servercore,pl:mixin:APP:servercore.common.mixins.json:features.spawn_chunks.ServerLevelMixin from mod servercore,pl:mixin:APP:servercore.common.mixins.json:optimizations.sync_loads.ServerLevelMixin from mod servercore,pl:mixin:APP:krypton.mixins.json:server.fastchunkentityaccess.ServerWorldMixin from mod krypton,pl:mixin:APP:seasons.mixins.json:ServerWorldMixin from mod seasons,pl:mixin:APP:canary.mixins.json:alloc.chunk_random.ServerLevelMixin from mod canary,pl:mixin:APP:canary.mixins.json:chunk.replace_streams.ServerLevelMixin from mod canary,pl:mixin:APP:canary.mixins.json:entity.inactive_navigations.ServerLevelMixin from mod canary,pl:mixin:APP:canary.mixins.json:profiler.ServerLevelMixin from mod canary,pl:mixin:APP:canary.mixins.json:util.accessors.ServerLevelAccessor from mod canary,pl:mixin:APP:canary.mixins.json:world.block_entity_ticking.sleeping.ServerLevelMixin from mod canary,pl:mixin:APP:aether.mixins.json:common.accessor.ServerLevelAccessor from mod aether,pl:mixin:APP:fabric-api-lookup-api-v1.mixins.json:ServerWorldMixin from mod fabric_api_lookup_api_v1,pl:mixin:APP:fabric-lifecycle-events-v1.mixins.json:ServerWorldMixin from mod fabric_lifecycle_events_v1,pl:mixin:APP:betterdeserttemples.mixins.json:ServerLevelMixin from mod betterdeserttemples,pl:mixin:APP:betterendisland.mixins.json:EndergeticExpansionMixins from mod betterendisland,pl:mixin:A,pl:connector_pre_launch:A}
at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[server-1.20.1-20230612.114412-srg.jar%23331!/:?] {re:mixin,pl:connector_pre_launch:A,re:classloading,pl:mixin:APP:canary.mixins.json:collections.entity_ticking.EntityTickListMixin from mod canary,pl:mixin:A,pl:connector_pre_launch:A}

Logs

No response

Additional context

No response

Describe the bug

My mod won't run due to a mixin error but I don't understand why. Works on equivalent Fabric for MC 1.20.1.

Steps to reproduce

1. Install OneBar 4.0.0, the Forge version of Cloth Config, Sinytra Connector, Forgified Fabric API, Connector Extras for Forge 47.2.0 on Minecraft 1.20.1
2. Try to run
3. Get a crash
   ...

Logs

Madis0/OneBar#72

Additional context

My mod only depends on Fabric API and Cloth Config and uses some mixins
Source: https://github.com/Madis0/OneBar/tree/1.20.1

Describe the bug

Pehkui crashes with Connector Extras 1.4.1. Works fine with only Sinytra Connector beta.19 and Forgified Fabric API 0.90.0 1.9.25

Steps to reproduce

1. Install Sinytra Connector beta.19, Forgified Fabric API 0.90.0 1.9.25 and Connector Extras 1.4.1
2. Add Pehkui
3. Crash at launch

Logs

https://pastebin.com/5DMfsW6K

Additional context

Tested with only Pehkui 3.7.8 forge, fabric seems to not be working too

Describe the bug

Unable to launch the game

Steps to reproduce

Load REI, REI Plugin Compatibilities and this mod together

Logs

https://gist.github.com/onecvly/112339ddd2ad7809d8446c3468d69286

Additional context

REI Plugin Compatibilities：This is an external REI module to workaround issues brought forward by mods accessing JEI apis, by remapping those usages back to their REI equivalent code.

Describe the bug

Connector is crashing on startup with Mythic Mobs saying AzureLibv was initialized too early, i have many fabric mods and never seemed to face this issue. i seen there was another bug issue like this with an eldrich mod and it was marked as solved, unfortunately mine is not and im not sure how to fix it. the exacr msg is " Caused by: mod.azure.azurelib.AzureLibException: AzureLib was initialized too early! at mod.azure.azurelib.cache.AzureLibCache.registerReloadListener(AzureLibCache.java:65) ~[azurelib-neo-1.20.1-2.0.20.jar%23279!/:2.0.20] {re:classloading} at mod.azure.azurelib.platform.NeoForgeAzureLibInitializer.initialize(NeoForgeAzureLibInitializer.java:13) ~[azurelib-neo-1.20.1-2.0.20.jar%23279!/:2.0.20] {re:classloading} at mod.azure.azurelib.AzureLib.initialize(AzureLib.java:25) ~[azurelib-neo-1.20.1-2.0.20.jar%23279!/:2.0.20] {re:classloading} at net.pixeldream.mythicmobs.MythicMobs.onInitialize(MythicMobs.java:21) ~[mythicmobs-1.20.1-fabric-1.4.5%20(2)_mapped_srg_1.20.1.jar%23699!/:?] {re:classloading} at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:129) ~[Connector-1.0.0-beta.40+1.20.1.jar%23257!/:1.0.0-beta.40+1.20.1] {} at dev.su5ed.sinytra.connector.mod.ConnectorLoader.load(ConnectorLoader.java:44) ~[Connector-1.0.0-beta.40+1.20.1-mod.jar%23264!/:1.0.0-beta.40+1.20.1] {re:mixin,re:classloading}"

Steps to reproduce

1. install mythic mobs 1.20.1 forge port (i also attempted this with fabric and it does the same azurelib crash)
2. install connector
   3.run ? (im so sorry i have never used github idk whatrt im doing
   ...

Logs

https://pastebin.com/2kkRDi2d

Additional context

No response

Describe the bug

When launching the game with Connector Extras, Fabric Geckolib and Critters and Companions, the game crashes.

Steps to reproduce

1. Install the following mods. Connector, Connector Extras, Critters and Companions, Forgified Fabric API, Geckolib Fabric.
2. Launch the game.

Logs

Additional context

No response

Describe the bug

Archers (RPG Series) Seems to crash with REI (Forge) installed.

Steps to reproduce

1. Install Archers RPG Series, REI Forge, Connector, Connector Extras, and all of their dependencies (Azurelib Armour (Forge), Spell Engine, Spell Power Attributes, Trinkets, Architectury Api (Forge), Projectile Damage Attribute, & Player Animator
2. Launch the game

Logs

https://pastebin.com/uLCSqj8g

Additional context

No response

Describe the bug

Fluid amounts in fabric mod recipes are all times 81 in EMI

Steps to reproduce

1. Open a recipe from a fabric mod with fluid input/outputs in EMI and hover over the fluid
   

Logs

No response

Additional context

When running on fabric EMI divides all fluid amounts by 81 so that they are really in mb and not in droplets. I made a quick fix with a mixin in the FluidEmiStack that throws an Exception and checks if any fabric mods are in the stacktrace and then divides it. There is probably a better solution.

Describe the bug

A startup crash occurs due to "Missing or unsupported mandatory dependencies", where Connector Extras isn't detecting Connector.

Steps to reproduce

1. Create a mods folder as a symbolic link, such that your launchers instance has the destination of the link
2. Add Sinytra Connector, Connector Extras, and Forgified Fabric API
3. Launch the instance
4. Startup crash will occur with error: "Missing or unsupported mandatory dependencies: Mod ID: 'connectormod', Requested by: 'connectorextras_architectury_bridge', Expected range: '[1.0.0-beta.18,)', Actual version: '[MISSING]'"

Logs

latest.log

Additional context

• Seems like Connector Extras isn't detecting Connector properly
• This was tested on Prism Launcher and CurseForge
• Only Connector Extras and its dependencies were used in the test
• The crash doesn't occur if my instance's mods folder is the source of a symlink

If you're wondering why I'd want to have a symlink, its because Prism can't export in the curse modpack format, and that adding/updating mods is a hassle with Prism, so I'm using CurseForge to manage the mods.

milk-lib is a Fabric mod that implements milk as a fluid. Other mods, such as Create Fabric and NEEPMeat, use it to avoid compatibility issues that would arise when multiple mods try to do such a thing.

If I recall correctly, (Neo)Forge already registers milk as a fluid as well (in some capacity). Perhaps there could be some sort of cross-compatibility for the two milk implementations in Connector Extras?

Several mods with EMI integration, such as xplat mods or Fabric mods that previously wanted to expose themselves through Sinytra, may have both added a class to their fabric entrypoint, and annotated it with @EmiEntrypoint. The current implementation seems like it would add these plugins twice, which will cause a whole host of unwanted behavior, like duplicate recipes. A "simple" solution is keeping track of all of the Classes that have already been picked up and ignoring the fabric entrypoints using those classes.

https://github.com/Sinytra/ConnectorExtras/blob/master/emi-bridge/src/main/java/dev/su5ed/sinytra/connectorextras/emibridge/mixin/EmiAgnosForgeMixin.java

Describe the bug

mixin conflict with reach entity attributes

Steps to reproduce

1.add the mods required to boot vs2, eureka, connector + extras
2. throw in create big cannons just to be safe
3. crash
...

Logs

https://gist.github.com/Xplodin/40305731d05955764ce79db7768ad308

Additional context

I believe both mods have a conflict with reach entity attributes
Looked at both mod's code

Describe the bug

Crash with Puzzle

Steps to reproduce

1.Install Puzzle and ConnectorExtras
2.Launch the game
3.Game crashes
...

Logs

https://pastebin.com/51Ldm0V9

Additional context

No response

Describe the bug

game crashes on mod loading if both mods are installed, seems like an issue with mixins

Steps to reproduce

1. install connector extras along with sinytra connector and forgified fabric api
2. install absolute ultracraft along with azurelib
3. launch the game

Logs

https://pastebin.com/UUK6gyk3

Additional context

Link to the mod in question: https://www.curseforge.com/minecraft/mc-mods/absolute-ultracraft

Describe the bug

Crash on start

Logs

https://gist.github.com/cococops/33d9c67104424a3ee3fb90f33054c245

Additional context

coco_00 from the sinytra connector discord found the issue caused by "ArchitecturyBridgeSetup" in the new update

Allow running EMI Fabric plugins on EMI Forge

Describe the bug

Using fabric version of geckolib the mod crashing when making an abstract_spell_casting_mob

Steps to reproduce

...

Logs

https://pastebin.com/5kG0bWcA

Additional context

No response

Describe the bug

food bar dissapeared after last update

Steps to reproduce

1.plays with 1.30
2.food bar present
3.update to b1.31
4.food bar dissapear

Logs

No response

Additional context

Hi I just update connector to last b1.31 and the food bar is gone.
I downgrade the version to b1.30 and it's there.

For the bars i have overflowwing bar for forge, Passive Skill Tree also who give skill for feeding.
I don't have any error message about, it's just not visually there, feeding work.

Describe the bug

Missing:org/sinytra/connector/loader/ConnectorEarlyLoader

Steps to reproduce

...

Logs

No response

Additional context

No response

Describe the bug

When using a fabric version of gecko lib, a mask item from Mowzie's Mobs will crash the game when its model form is rendered (such as when equipped). I got another crsah from this mod as well without equipping this mask, crash logs seem to indicate its being rendered in an item frame somewhere.

Steps to reproduce

1. Install Mowzie's Mobs and a fabric version of Gecko Lib
2. Equip an Umvuthana Mask
3. Open your inventory or enter 3rd person
4. The game crashes

Logs

https://gist.github.com/AvaloriaSinytra/2e4f964920ebeb77a8f3ba1ca677b136

Additional context

Saw quark and botania mentioned in the log, hopefully thats not causing this somehow. I'm using fabric gecko lib because of a fabric mod that requires it (Marium's soulslike weaponry).

Describe the bug

crashes on startup

Steps to reproduce

...

Logs

No response

Additional context

No response

Describe the bug

Mouse Wheelie is a mod that 'embeds parts of Amecs'. It seems to function fine with Connector Extras (Slot Refill feature works) but never accepts any keystroke.

Steps to reproduce

1. Install Mouse Wheelie (1.13.0+mc1.20.1) alongside with Connector Extras (1.8.0)
2. Launch the game
3. Try sorting inventory with a Middle Click, opening the config screen after binding any key, or doing basically anything that involves keybinding

Logs

It seems no log contains the information associated the issue.

Additional context

No response

Describe the bug

Can't charge techreborn tools with connector extras

Steps to reproduce

1. Have RF generated by mekanism and store in the induction matrix
2. Craft the electric treetap from techreborn
3. Place the tool into the machines or matrix to try to charge
4. Notice that power is used but is not charged

...
Notice output of RF/t

Notice the new output and how much energy is in the tool after being placed inside.

Power is being used but ends up being voided as it is not converted properly.

Logs

N/A

Additional context

Mods
MekanismGenerators-1.20.1-10.4.2.16.jar
Mekanism-1.20.1-10.4.2.16.jar
fabric-api-0.90.0+1.9.27+1.20.1.jar
TechReborn-5.8.7.jar
Connector-1.0.0-beta.19+1.20.1-full.jar
ConnectorExtras-1.4.1+1.20.1.jar

Additional context: I noticed that when I put a tool (that previously was charged on the tech reborn machines without connector extras) inside a tech reborn machine it actually drains the power from the tool as if it was a battery. Again does not gain any power.

Describe the bug

Try the latest continiuty with connector extra but failed

Steps to reproduce

1. install sinytra, connector extra and continiuty
2. launch the game
3. crash on startup
   ...

Logs

https://mclo.gs/1ZSNB8g

Additional context

latest continiuty: https://modrinth.com/mod/continuity/version/3.0.0-beta.5+1.20.1

Mod Name

PowerAE2CC Bridge (Any addon for CC: Tweaked Fabric)

Mod Homepage

https://modrinth.com/mod/powerae2cc

Minecraft version

1.20.1

Describe the bug

CC: Tweaked has different api for platforms

Steps to reproduce

Just install and launch, you get a crash

Logs

https://pastebin.com/ixYg2dhn

Additional context

Most likely needed in Connector Extras

Describe the bug

"Config" button for Dynamic Surroundings is clickable in Mods menu, which is different in native Fabric or even when replacing ConnectorExtras with ModMenu.

Steps to reproduce

• install Connector Extras and all its dependencies.
• install Dynamic Surroundings

and go to Dynamic Surroundings in mod list

• remove Connector Extras
• install Mod Menu

and go to Dynamic Surroundings in mod list

Logs

with Catalogue (crash):
https://pastebin.com/raw/pSdE2TN5

without Catalogue (not crash):
https://pastebin.com/raw/ACv8YL6Y

Additional context

Both in NeoForge primitive Mods menu (i.e. without Catalogue installed) and in Catalogue menu the button is clickable. However, clicking it crashs the game in Catalogue, while nothing happens (except for a similar NullPointerException stacktrace) in the primitive menu.

Describe the bug

Connector Extras will crash AzureLib because it loads "too early", this doesn't happen on fabric.

Steps to reproduce

1. Install Connector, Connector Extras and FFAPI
2. Install AzureLib for forge, and a mod that depends on it (like Eldritch End)
3. It will crash due to a geckolib compatibility mixin having a higher priority on the latest versions, since then, AzureLib will fail to load.

Logs

https://mclo.gs/u5ythth

Additional context

This seems to happen after this mixin was changed to have a priority of 2000. Older versions of Connector Extras make the mod load fine, and this also does not happen on fabric.