Coder Social home page Coder Social logo

Comments (9)

gabor1 avatar gabor1 commented on June 5, 2024 1

Thanks. I haven't explicitly said, but perhaps should, that I am a keen supporter of other implementations of SOAP (especially ones like dscribe with improved radial basis), the quippy one is just for reference.

from dscribe.

lauri-codes avatar lauri-codes commented on June 5, 2024 1

Now fixed in 0.4.0. Thanks again @gabor1!

from dscribe.

lauri-codes avatar lauri-codes commented on June 5, 2024

Hi Gabor!

Thanks for reporting this. I think I understand your point. I will have to check our implementation to see if we are truly misusing symmetry here. If so, this should be fixed ASAP.

from dscribe.

gabor1 avatar gabor1 commented on June 5, 2024

from dscribe.

gabor1 avatar gabor1 commented on June 5, 2024

it's a funny terminology to label this "enhancement" ...

from dscribe.

lauri-codes avatar lauri-codes commented on June 5, 2024

I looked at this briefly, and indeed it seems to be a bug on our side. Now labeled correctly. Now I just need to find the time to fix it.

from dscribe.

lauri-codes avatar lauri-codes commented on June 5, 2024

Great, your input is very much appreciated!

from dscribe.

lauri-codes avatar lauri-codes commented on June 5, 2024

This is more of a note for future reference:

The individual terms in the multi-species power spectrum are of the form:

So the question is, what terms are redundant due to symmetry? One way to analyze the symmetries is by taking the complex conjugate of the power spectrum (taking the complex conjugate doesn't affect the result as the power spectrum terms are real numbers):

This shows that swapping both n and Z simultaneously creates identical output:

As @gabor1 already mentioned, this symmetry can be very neatly taken into account by using combined indices (Z,n) and (Z',n') and adding only values for which (Z',n') >= (Z,n). The combined indices can be represented directly as python tuples as they have a suitable comparison operator.

from dscribe.

gabor1 avatar gabor1 commented on June 5, 2024

great, thanks!

from dscribe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.