Broken brew install about afflibv3

[simsong]

Okay. Do you want to submit a patch?

---

Sent from my phone. Please Call me at 202-322-8411 if you wish a longer response.

On Nov 15, 2013, at 3:40 PM, Ventz Petkov [email protected] wrote:

Hi,

I noticed that the upgrade to afflib 3.7.3 produces:

% brew upgrade
==> Upgrading 1 outdated packages, with result:
afflib 3.7.3
==> Upgrading afflib
==> Downloading https://github.com/simsong/AFFLIBv3/archive/v3.7.3.tar.gz
######################################################################## 100.0%
==> sh bootstrap.sh
==> ./configure --prefix=/usr/local/Cellar/afflib/3.7.3
==> make install
^
8 errors generated.
make[1]: *** [affinfo.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
—
Reply to this email directly or view it on GitHub.

[ventz]

Let me look into why this is happening. Here is a better error message by
the way (i wasn't sure if this was something that you knew about already):

/usr/include/openssl/md5.h:116:16: note: 'MD5' declared here

unsigned char *MD5(const unsigned char *d, size_t n, unsigned char *md)
DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;

               ^

affinfo.cpp:839:12: error: reference to 'error_code' is ambiguous

    return(error_code);

           ^

affinfo.cpp:58:14: note: candidate found by name lookup is 'error_code'

unsigned int error_code = 0x00;

             ^

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/system_error:474:24:
note: candidate found by name lookup is

      'std::__1::error_code'

class _LIBCPP_TYPE_VIS error_code

                       ^

affinfo.cpp:839:12: error: reference to 'error_code' is ambiguous

    return(error_code);

           ^

affinfo.cpp:58:14: note: candidate found by name lookup is 'error_code'

unsigned int error_code = 0x00;

             ^

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/system_error:474:24:
note: candidate found by name lookup is

      'std::__1::error_code'

class _LIBCPP_TYPE_VIS error_code

                       ^

affinfo.cpp:839:23: error: expected expression

    return(error_code);

                      ^

8 warnings and 8 errors generated.

make[1]: *** [affinfo.o] Error 1

make: *** [install-recursive] Error 1

[ventz]

I think I found the problem - the unsigned int can't be called "error_code".

It also looks like you have already fixed in github:
https://github.com/simsong/AFFLIBv3/blob/3cb7091c793e91e5d21c95e57b88abe6f1ac8953/tools/affinfo.cpp

Would it be possible to push that version out into a packaged release?

[simsong]

I know that one. Apple created a new global variable called error_code. Change mine to another name.

---

Sent from my phone.

On Nov 15, 2013, at 4:12 PM, Ventz Petkov [email protected] wrote:

Let me look into why this is happening. Here is a better error message by
the way (i wasn't sure if this was something that you knew about already):

/usr/include/openssl/md5.h:116:16: note: 'MD5' declared here

unsigned char *MD5(const unsigned char *d, size_t n, unsigned char *md)
DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;

^

affinfo.cpp:839:12: error: reference to 'error_code' is ambiguous

return(error_code);

^

affinfo.cpp:58:14: note: candidate found by name lookup is 'error_code'

unsigned int error_code = 0x00;

^

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/system_error:474:24:
note: candidate found by name lookup is

'std::__1::error_code'

class _LIBCPP_TYPE_VIS error_code

^

affinfo.cpp:839:12: error: reference to 'error_code' is ambiguous

return(error_code);

^

affinfo.cpp:58:14: note: candidate found by name lookup is 'error_code'

unsigned int error_code = 0x00;

^

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/system_error:474:24:
note: candidate found by name lookup is

'std::__1::error_code'

class _LIBCPP_TYPE_VIS error_code

^

affinfo.cpp:839:23: error: expected expression

return(error_code);

^

8 warnings and 8 errors generated.

make[1]: *** [affinfo.o] Error 1

make: *** [install-recursive] Error 1

On Fri, Nov 15, 2013 at 3:54 PM, Simson L. Garfinkel <
[email protected]> wrote:

Okay. Do you want to submit a patch?

---

Sent from my phone. Please Call me at 202-322-8411 if you wish a longer
response.

On Nov 15, 2013, at 3:40 PM, Ventz Petkov [email protected]
wrote:

Hi,

I noticed that the upgrade to afflib 3.7.3 produces:

% brew upgrade
==> Upgrading 1 outdated packages, with result:
afflib 3.7.3
==> Upgrading afflib
==> Downloading
https://github.com/simsong/AFFLIBv3/archive/v3.7.3.tar.gz
########################################################################
100.0%
==> sh bootstrap.sh
==> ./configure --prefix=/usr/local/Cellar/afflib/3.7.3
==> make install
^
8 errors generated.
make[1]: *** [affinfo.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-28602543
.

-Ventz
http://vpetkov.net
—
Reply to this email directly or view it on GitHub.

[simsong]

You know, I think we fixed that one already...

---

Sent from my phone. Please Call me at 202-322-8411 if you wish a longer response.

On Nov 15, 2013, at 4:23 PM, Ventz Petkov [email protected] wrote:

I think I found the problem - the unsigned int can't be called "error_code".

It also looks like you have already fixed in github:
https://github.com/simsong/AFFLIBv3/blob/3cb7091c793e91e5d21c95e57b88abe6f1ac8953/tools/affinfo.cpp

Would it be possible to push that version out into a packaged release?

—
Reply to this email directly or view it on GitHub.

[ventz]

Yea you did fix it. It's in the latest github push.

I think you just need to push out a new tar ball in the archive :)

[simsong]

Done.