size_t strlcpy & strlcat problem - OSX/Mavericks related about afflibv3

[ventz]

Ok. Added the fix (a proper one, with a check in the lib), and did a pull request.

[simsong]

I think that your patch is wrong. Can you check your configure.ac file and see if there is a test for strlcpy?

[simsong]

Okay. I think that I understand your problem. AFFLIB is compiling just fine on your system, but you are including it in _ANOTHER PROJECT_ and that project is not testing for strlcpy in its configure.ac file. I think that your patch breaks AFFLIB on other platforms that do not have strlcpy.

[ventz]

Interesting. Is the check not firing correctly?

There isn't anything in configure.ac by the way(this is for sleuthkit)

What I noticed is that even though there is a check for HAVE_STR*** in afflib_i.h, it doesn't seem to get called correctly, but that would make sense if it was never in the configure - which is for SleuthKit and not afflib.

[simsong]

This is a known sleuthkit bug that has been separately reported. Sleuthkit’s configure.ac file is missing the check. It needs to be added there.

The problem is not AFFLIB.

On Nov 21, 2013, at 1:25 PM, Ventz Petkov [email protected] wrote:

Interesting. Is the check not firing correctly?

There isn't anything in configure.ac by the way(this is for sleuthkit)

What I noticed is that even though there is a check for HAVE_STR*** in afflib_i.h, it doesn't seem to get called correctly, but that would make sense if it was never in the configure - which is for SleuthKit and not afflib.

—
Reply to this email directly or view it on GitHub.

[ventz]

I submitted the info on Sleuthkit's github page. Hopefully they will patch. I wonder why they haven't if they knew about it. This is something very small and simple, yet it effects so many users.

Thanks for looking into it by the way, and for the information.