Comments (6)
Ok. Added the fix (a proper one, with a check in the lib), and did a pull request.
from afflibv3.
I think that your patch is wrong. Can you check your configure.ac
file and see if there is a test for strlcpy
?
from afflibv3.
Okay. I think that I understand your problem. AFFLIB is compiling just fine on your system, but you are including it in _ANOTHER PROJECT_ and that project is not testing for strlcpy in its configure.ac
file. I think that your patch breaks AFFLIB on other platforms that do not have strlcpy
.
from afflibv3.
Interesting. Is the check not firing correctly?
There isn't anything in configure.ac by the way(this is for sleuthkit)
What I noticed is that even though there is a check for HAVE_STR*** in afflib_i.h, it doesn't seem to get called correctly, but that would make sense if it was never in the configure - which is for SleuthKit and not afflib.
from afflibv3.
This is a known sleuthkit bug that has been separately reported. Sleuthkit’s configure.ac file is missing the check. It needs to be added there.
The problem is not AFFLIB.
On Nov 21, 2013, at 1:25 PM, Ventz Petkov [email protected] wrote:
Interesting. Is the check not firing correctly?
There isn't anything in configure.ac by the way(this is for sleuthkit)
What I noticed is that even though there is a check for HAVE_STR*** in afflib_i.h, it doesn't seem to get called correctly, but that would make sense if it was never in the configure - which is for SleuthKit and not afflib.
—
Reply to this email directly or view it on GitHub.
from afflibv3.
I submitted the info on Sleuthkit's github page. Hopefully they will patch. I wonder why they haven't if they knew about it. This is something very small and simple, yet it effects so many users.
Thanks for looking into it by the way, and for the information.
from afflibv3.
Related Issues (11)
- affconfig.h is missing HOT 3
- http://afflib.org/ HOT 3
- Incompatible license with FUSE
- tools/affuse.c license HOT 2
- affconvert X file extensions HOT 29
- Typo singed/signed in README HOT 6
- This is not the AFFLIB you are looking for
- "FUSE IS NOT SUPPORTED ON MACOS" HOT 2
- qa warning: overflow destination buffer HOT 4
- Broken brew install HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from afflibv3.