simplemachines / buildtools Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 16.0 108 KB

Build Tools for SMF

License: BSD 3-Clause "New" or "Revised" License

PHP 98.85% Shell 1.15%

buildtools's People

Contributors

Stargazers

Watchers

Forkers

kant colinschoen sesquipedalian missallsunday live627 brickozp sbulen jdarwood007 kooms97 global-localhost global19 global19-atlassian-net

buildtools's Issues

Ignore list loop continues wrong loop

BuildTools/generateDetailedVersion.php

Lines 95 to 105 in 764a01d

    
           foreach ($files as $file) 
        
           { 
        
           	$basename = basename($file); 
        
           	// Skip index files. 
        
           	if ($basename == 'index.php' && $location != 'SMF') 
        
           		continue; 
        
           	// Skip these files. 
        
           	foreach ($ignoreFiles as $if) 
        
           		if (preg_match($if, $basename)) 
        
           			continue;

The continue keyword on line 105 continues looping through the ignore list , which may be a bug. Specifying continue 2 skips to the next file. IOW, it goes on to the next iteration of the outer loop.

Newline before EOF

check-eof.php should accept files ending with an empty line, otherwise Travis CI will fail for lots of valid files.
It's a de facto standard to have 1 trailing newline in text files.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	foreach ($files as $file)
	{
	$basename = basename($file);

	// Skip index files.
	if ($basename == 'index.php' && $location != 'SMF')
	continue;
	// Skip these files.
	foreach ($ignoreFiles as $if)
	if (preg_match($if, $basename))
	continue;