simon-lammes / shared-concepts Goto Github PK

Requested Feature

After logging in you see your profile picture and name. By clicking on it, you are navigated to the profile page. There you can set your profile to public. After that you are able to search other public profiles. This will be the foundation for a 1v1 mode where you can challenge a friend with exercises on topics both of you choose.

Technical implementation

• There should be a profiles collection in the root of firestore. The key of each profile is its associated user id.

Travis CI offers environment variables. Maybe the keys can be put there. Affected are the following tokens:

• Travis CI secure token

• messagingSenderId in environment.prod.ts

• apiKey of firebase in environment.prod.ts

This blog post describes setting up Travis CI in a very similar environment to this one.

The user should be able to revert his changes to the settings. Therefore, when a user changes his settings, his previous settings should be saved inside a NGXS state model. When he presses a revert button or "Strg + Z" the user goes back to his previous settings. It is okay to store the previous settings in localstorage but the list of previous settings should not grow endlessly.

Problem

Currently all top level concepts are loaded when the concept state is initialized. This means they are also leaded when the user does not navigate to the concepts page. Also the top level concepts do not have to be loaded when the user just navigates to a specific concept like so: '/concepts/Neurology'.

Task

The top level concepts should only be loaded when the user requests to see them by navigating to '/concepts'.

Possible Procedure

• In the concept page, check whether a concept key is provided in the url. If not, the user currently navigated to the top level concepts page.
• In that case trigger the loading of the top level concepts. It would be nice if name of the action is changed so that it matches the naming convention of being passive. Suggestion: TopLevelConceptsRequested
• You can verify the correct behavior by deleting localstorage and afterwards directly navigating to a url other than '/concepts'. When the network tab shows no backend calls for fetching top level concepts, you succeeded.

Currently the concept.page.ts is responsible for filtering the displayed concepts. Instead this logic should be put inside a parameterized selector inside the concept.state.ts. This selector should take the concept key (to which the user currently traversed) and return the concepts that should be presented to the user. If no key is provided the user did not navigate at all and should be seeing the top level concept.

The same structural change should be made for the inspectedConcept$ inside the concept.page.ts.