simh / simtools Goto Github PK

incorrect processing of strings like '<<>>'
File parce.c
Line 610 strcpy(endstr, "<>\n");
If write strcpy(endstr, ">\n") then OK
spal11.mac.txt

The README.md says:
mtdump Dump the record structure of a SIMH, E11, TPC, or P7B

and:
simtools/extracters/mtdump/mtdump.txt

also talks about processing P7B files, but the code doesn't handle such files
or a -p option, at all. That needs to be fixed in the documentation.

Looking at mtdump.c, I can see that files in P7B format don't fit well in the code,
as I think all of the other formats use a header that gives the record length, but P7B
(aka Paul Pierce format) don't have any headers or trailers, just a stream of
bytes with 6-bit char codes, a parity bit, and a 'new record starting' bit, plus
a special byte value (0x8F) to signify a tape mark.

According the MACRO-1 docs, constant syllables are defined by parentheses, but obviously this should not be the case if the parentheses appear inside a comment from / to end of line. It appears that macro1.c is not ignoring them, though.

I am trying to assemble the source for the famous MIT display hacks available here: http://bitsavers.trailing-edge.com/bits/DEC/pdp1/from_peter_samson/dpys5.mac

I get all kinds of confusing errors about undefined symbols and illegal expressions. Inspection of the listing output suggests that it is attempting to parse the comments.

When the parens are removed from the following comments, the source assembles cleanly:

line 6: / (uses TW)
line 15: / (uses no switches)
line 258: / (uses TW)

I'm attaching the errors and listing output.

I haven't yet studied the macro1 code long enough to understand how it works; if I have time, I will try to develop a patch and submit a pull request. I decided to go ahead and file the bug in the hopes that someone more familiar with the code than I will beat me to it.

Simtools is licensed for most files, but some of them (mainly Makefiles) are unlicensed.
It's a good idea to add a parent license. Something like:

1. All our contributions are freely available for use, copying, distribution in their original and modified form, but without any warranty.
2. All Makefiles and documentation files are licensed under the license describes in the source code of the program.
3. Third party programs may be licensed in their own right, but section 2 applies to them.