simeonreusch / planobs Goto Github PK

Is your feature request related to a problem? Please describe.
I'm always frustrated when I'm trying to use planobs as a dependency, because the poetry dependency requirements are very strict. It makes it hard to ensure compatibility with other projects.

In general, the poetry model is great for a final-level analysis code which should be exactly reproducible, but bad for generic utility packages which are imported by a lot of other packages. It seems like planobs is in the second category, with three downstream packages so far.

Describe the solution you'd like
I would think the package could be more widely/easily used if either the poetry requirements were substantially loosened, or the entire dependency system was moved to setuptools with minimal constraints on e.g python version <3.12, or pandas ==1.4.x

Describe alternatives you've considered
This might be out of scope, because the package does it's core function fine as is. So things could be left as they are.

Describe the bug
If the airmass requirement is fulfilled, but the resulting observation time is too short for the required observation length and separation between bands, an error occurs.

To Reproduce
Run

from planobs.plan import PlanObservation
PlanObservation(name="IC231211A", alertsource="icecube")

and see traceback:

File ~/Software/planobs/planobs/plan.py:322, in PlanObservation.__init__(self, name, ra, dec, arrivaltime, date, max_airmass, observationlength, bands, multiday, alertsource, obswindow, site, switch_filters, verbose, **kwargs)
    317     self.g_band_recommended_time_start = utils.round_time(
    318         g_band_obsblock[0]
    319     )
    320     self.g_band_recommended_time_end = utils.round_time(g_band_obsblock[-1])
    321     self.r_band_recommended_time_start = utils.round_time(
--> 322         r_band_obsblock[0]
    323     )
    324     self.r_band_recommended_time_end = utils.round_time(r_band_obsblock[-1])
    326 else:

IndexError: list index out of range

Expected behavior
planobs checks for this case and saves something like not observable due to short observation window.