silvershop / silvershop-comparison Goto Github PK

is there any reason why you didn't allow features to be in multiple groups. It seems crazy to create 2 features exactly the same just to be able to assign them to 2 separate groups? Or am i missing something?

Features could be assigned one of a few types:

• boolean - eg: yes/no
• float - eg: 124.44
• int - eg: 325
• enum - eg: snapdragon 1.5ghz

This selection can help with entering and presenting data.

Regarding presentation, the value could be wrapped in a Varchar, Boolean, or Float field ...relative to which value type the feature has.

It seems this module it not yet updated for SS4.

ie. the class Feature has the old style class references:

`

private static $has_many = array(
"Products" => "Product_Feature"
);

private static $has_one = array(
    "Group" => "FeatureGroup"
);

private static $belongs_many_many = array(
    "Product" => "Product"
);`

The Float object name is reserved in PHP 7 and needs to be chanegd to DBFloat

This line of codes needs to be updated to make the module still work.

Could you please add the module to scrutinizer? https://scrutinizer-ci.com/g/new. We're keeping track of all modules we use on our contributions dashboard (github-dashing.herokuapp.com), and I've added scrutinizer quality and coverage scores there. Doesn't require any config, just four clicks. You'll have to click "Schedule inspection" for the first run, after that it should kick off automatically on commits.

There's banners you can copy paste into your README if you want. Also, if you feel like it, you could also add me as a collaborator :) There's a "Add collaborators to your repository" option on the homepage.

We're experimenting with a more fine tuned config, including code coverage running on travis, but that's not really to roll out yet (https://github.com/stojg/silverstripe-timeline). Happy to hear feedback and get help of course :)

Allow entering arbitrary values, instead of needing to predefine them.
Use a ajax lookup field when entering values, so that we can re-use existing data. This shouldn't apply to numeric and boolean features.

Running composer require silvershop/comparison on an SS4 site installs an incompatible ^1.0 version, because:

• The 1.0.0 tag requires silvershop/core: *
• There's no released version of the module targeting silvershop/core: ^3

Running composer require silvershop/comparison dev-master works, but requires knowing about the problem and how to fix it - otherwise you just get errors about DataExtension not being a valid class which take time to figure out.

If it's stable, could we get a v2.0, and update the 1.0 line to target silvershop/core <3?

I'd make the pull requests, but there's only a tag for the older version, and I can't make releases anyway.