silshack / summer2017 Goto Github PK

Header doesn't include double quotation marks in the title:

title: Brian's Logical Trinket Post

@abaker8 check the spaces in front of your hyphens: https://raw.githubusercontent.com/silshack/summer2017/gh-pages/_posts/abaker8/2017-06-08-Amandas-reflection-on-Brians-game.md

@jbfelder you listed your layout as postff in #73 and #107. This makes your posts show up bare: https://silshack.github.io/summer2017/jbfelder-Logical-Turtle-Exercises.html

Remove those and we're good to go.

looks good to me, although that doesn't mean much cause I'm an amateur.

This is a test issue. I'm not sure that you have any problems.

@businessowl see PR #48

First Post: His first post has all of the components and looks good. His post made me hungry for pizza!
First Post Edit: His edits to his first post also look good.
Turtle Hack Post: He had a different trinket link, but is going to edit it! After that, it'll look perfect.

summer2017/_posts/elliott/2017-06-12-apr7notes.md is the post in question.

The 2nd trinket link (https://trinket.io/python3/7ab711043e) has a potential error on line 85.

It currently says print(key, maxemails)

I believe it should be print(emailer, maxemails)

The only thing was instead of putting her github name she out "your github name" as per when we went through it in class. The same with the title she put in.

The title was ending with .m instead of .md, but I think you fixed it.

Need quotes on title @neatoskeeto

I noticed a minor issue while reading through the reflection on your pull request.

You said the following, "using (“to,go”) code to...", reference the go.to command,

We learned today in class to use back ticks, below the tilde, to talk about code in Github, while I'm still uncertain whether its necessary to use them for commands it could be useful.

There's no closing quotation mark in the title field.

Your code sucks! Jk this is a test. You failed! Jk again. Good job.

@chausuble Check the location of this post https://github.com/silshack/summer2017/tree/gh-pages/summer2017/_posts/chausuble

@nurahill this isn't displaying correctly:

https://silshack.github.io/summer2017/nura-turtle-drawing-app.html

Seems like the header was copied and pasted from a diff so it's got a bunch of +s in front of it.

Had trouble with proper setup by forgetting to include setting a title and author, but she easily fixed it with another post that she uploaded later on!

@lisetted in your logical turtles post in #83 you've listed your author name a Lisette. It needs to be your github user name for your author details to show up.

@chall12 check your app reflection and your peer review. The spaces before your paragraphs (i.e. indentation) are interpreted as code blocks (that's an alternate way to write code beyond using backticks). Removing the extra spaces before each paragraph will fix this.