sija / gphoto2.cr

Crystal shard wrapping libgphoto2

gphoto2.cr's Issues

Invalid memory access while using Context#error_callback

When trying to access CameraFile#get_data_and_size on disconnected camera.

Exception log:

2016-08-12 00:14:33 +0200 200 GET /cameras/ypBMNRNh0xq75z/fs/store_00010001/DCIM/101APPLE/IMG_1480.JPG 455.75ms
DEBUG [gphoto2.cr] -- [4544243908] *GPhoto2::CameraFile#new:Pointer(LibGPhoto2::CameraFile) +36 -- {rc} = {0}
DEBUG [libgphoto2] -- Getting file info for 'IMG_1480.JPG' in '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Getting information about 'IMG_1480.JPG' in '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Lookup folder /store_00010001/DCIM/101APPLE file IMG_1480.JPG
DEBUG [libgphoto2] -- Lookup folder '/store_00010001/DCIM/101APPLE'...
DEBUG [gphoto2.cr] -- [4544249263] *GPhoto2::CameraFile#get_info:GPhoto2::CameraFileInfo +4863 -- {rc} = {0}
DEBUG [libgphoto2] -- Getting file info for 'IMG_1480.JPG' in '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Getting information about 'IMG_1480.JPG' in '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Lookup folder /store_00010001/DCIM/101APPLE file IMG_1480.JPG
DEBUG [libgphoto2] -- Lookup folder '/store_00010001/DCIM/101APPLE'...
DEBUG [gphoto2.cr] -- [4544249263] *GPhoto2::CameraFile#get_info:GPhoto2::CameraFileInfo +4863 -- {rc} = {0}
DEBUG [libgphoto2] -- Getting file 'IMG_1480.JPG' in folder '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Getting file 'IMG_1480.JPG' from folder '/store_00010001/DCIM/101APPLE' (type 1)...
DEBUG [libgphoto2] -- Lookup folder /store_00010001/DCIM/101APPLE file IMG_1480.JPG
DEBUG [libgphoto2] -- Lookup folder '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- Downloading 'IMG_1480.JPG' from folder '/store_00010001/DCIM/101APPLE'...
DEBUG [libgphoto2] -- (storage=0x00010001, handle=0x00000000)
DEBUG [libgphoto2] -- (storage=0x00010001, handle=0x00000001)
DEBUG [libgphoto2] -- (storage=0x00010001, handle=0x00000032)
DEBUG [libgphoto2] -- Getting file 'IMG_1480.JPG'.
DEBUG [libgphoto2] -- Sending PTP_OC 0x1009 (Get object) request...
ERROR [libgphoto2] -- 'libusb_bulk_transfer (port->pl->dh, port->settings.usb.outep, (unsigned char*)bytes, size, &curwritten, port->timeout)' failed: No such device (it may have been disconnected) (-4)
ERROR [libgphoto2] -- Writing 16 = 0x10 bytes to port failed: Could not find the requested device on the USB port (-52)
ERROR [libgphoto2] -- PTP_OC 0x1009 sending req failed: Could not find the requested device on the USB port (-52)
ERROR [libgphoto2] -- 'ret' failed: 'PTP I/O Error' (0x02ff)
ERROR [libgphoto2] -- PTP I/O Error
Invalid memory access (signal 11) at address 0x0
[4543072923] *CallStack::print_backtrace:Int32 +107
[4542975527] __crystal_sigfault_handler +55
[140735736141098] _sigtramp +26

[ask] Can i use this library with my laptop camera ?

Migrate code to Crystal v0.19

Write specs

Xiomi phone, your camera doesn't support generic capture

i do

gphoto2 --summary --debug --debug-logfile=logfile.txt

logfile.txt
logfile.txt

Implement Camera#storage_info

Based on gp_camera_get_storageinfo.

Fix and complete documentation

crystal doc

Support calling timeout functions

Sth along the lines of:

private def set_timeout_funcs
  start_func = ->(camera_ptr : LibGPhoto2::Camera*, timeout : LibC::UInt, func : LibGPhoto2::CameraTimeoutFunc, data : Void*) {
    # can we use .as() for GC-ed crystal object without blowing up?
    camera = data.as?(Camera) || return LibGPhoto2::GP_ERROR
    return LibGPhoto2::GP_ERROR if camera_ptr != camera.ptr
    spawn do
      loop do
        # break if camera.disposed?
        sleep timeout.seconds
        # GPhoto2.check! ?
        func.call(camera.to_unsafe, camera.context.to_unsafe)
      end
    end
    camera_ptr.value.hash
  }
  stop_func = ->(camera_ptr : LibGPhoto2::Camera*, id : LibC::UInt, data : Void*) {
    # how do we cleanup, if at all?
  }
  # Need to use `@ptr` instead of `self`, since we call
  # `#init` inside of overridden `#ptr` method.
  LibGPhoto2.gp_camera_set_timeout_funcs(@ptr, start_func, stop_func, self.as(Void*))
end

References:

• http://www.gphoto.org/doc/api/gphoto2-camera_8h.html#af2e448cda5a2a1637d497fec7b89c44f
• https://github.com/lonelyelk/gphoto4ruby/blob/master/ext/gphoto2camera.c#L117
• http://marc.info/?l=gphoto-devel&m=102069893029378

From what I've seen in libgphoto2 codebase, the only camera driver currently using this feature is Konica.

Add Code of Conduct

http://contributor-covenant.org/version/1/4/

Get rid of FIXME marked issues

Include Enumerable module where appropriate

See CameraList, CameraFolder...

v0.1

Meta-ticket for v0.1 release

Port:

• enumeration

Camera:

• selection
• reading abilities
• capture & preview
• filesystem operations
• events (like waiting for a file being added)
• reading config tree
• writing config settings

Add CameraFileInfo and related structs/enums

Support observing Camera events

Like below:

camera.on :file_added do |event|
  # ...
end

Cache instance properties which can lead to gp_* calls

Some of the candidates would be CameraWidget, Entry or CameraFile.
We'd also need some #reset method for clearing out those.

Building on linux

/usr/bin/ld: cannot find -llibgphoto2
collect2: error: ld returned 1 exit status
Error: execution of command failed with code: 1: `cc -o "/home/sija/.cache/crystal/crystal-run-spec.tmp" "${@}"  -rdynamic  -llibgphoto2 -lxml2 -lpcre -lm -lgc -lpthread /opt/crystal/src/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

Calling Camera#file fails for queued calls

It happens when (there's no SD card inside? and) we try to use CameraFile which might be unavailable at the time.

Below test code:

queue = [] of CameraFile
# ...
queue.each &.save

Results in:

Unspecified error (GPhoto2::Error)
[4491010242] *CallStack::unwind:Array(Pointer(Void)) +82
[4491010145] *CallStack#initialize:Array(Pointer(Void)) +17
[4491010104] *CallStack::new:CallStack +40
[4490990009] *raise<GPhoto2::Error>:NoReturn +25
[4491164503] *GPhoto2::check!<Int32>:Int32 +919
[4491237226] *GPhoto2::Camera@GPhoto2::Camera::Filesystem#file_get<GPhoto2::CameraFile, LibGPhoto2::CameraFileType>:GPhoto2::CameraFile +250
[4491236967] *GPhoto2::Camera@GPhoto2::Camera::Filesystem#file_get<GPhoto2::CameraFile>:GPhoto2::CameraFile +39
[4491236921] *GPhoto2::Camera@GPhoto2::Camera::Filesystem#file<GPhoto2::CameraFile>:GPhoto2::CameraFile +9
[4491425206] *GPhoto2::CameraFile#data_and_size:Tuple(Pointer(UInt8), UInt64) +134
[4491425040] *GPhoto2::CameraFile#data:Pointer(UInt8) +32
[4491424949] *GPhoto2::CameraFile#to_slice:Slice(UInt8) +21
[4491424546] *GPhoto2::CameraFile#save:Nil +130
[4490921895] __crystal_main +2583
[4490974088] main +40

#unref vs #free

In many places, like CameraWidget for instance: https://github.com/gphoto/libgphoto2/blob/548e52bb598fd8d38ca4a0ec3f619e936517bdf1/libgphoto2/gphoto2-widget.c#L177

Refs #16

Check for memory leaks

There are plenty places where those might happen, might be related to #14.

Implement support for GP_WIDGET_BUTTON

Used by just 2 (sierra & kodak) drivers, might be not worth implementing.

#finalize vs #close mismatch

In Crystal #finalize method acts like a destructor, called when the object is being collected by GC but in some of the classes we use it also to free up C (mostly libgphoto2) resources which might introduce bugs later on—or not?

CameraWidget#set_value argument overloading problem

in ./src/gphoto2/camera_widget.cr:66: no overload matches 'GPhoto2::DateCameraWidget#set_value' with type String

Path constructed via File.join might blowup on Windows due to \\ File::SEPARATOR

https://github.com/Sija/gphoto2.cr/blob/master/src/gphoto2/camera_folder.cr#L32

CameraFolder.new(@camera, File.join(@path, name))

https://github.com/Sija/gphoto2.cr/blob/master/src/gphoto2/camera/event.cr#L29

CameraFolder.new(self, File.join(path.folder, path.name))