signbank / signbank-video Goto Github PK

@henrinie said:
We need a way to connect uploaded videos that don't have a Gloss set (yet) to a Dataset.
I wonder if TaggedVideo could be used like this to solve this issue?

category="dataset"
tag=dataset.pk

Would it make sense to make use of the contenttypes framework to handle relations? It would allow us have generic relations based on the contenttypes, like explained in https://docs.djangoproject.com/en/1.10/ref/contrib/contenttypes/#generic-relations
Is there a requirement to have categories that are not models?

I guess this:

class TaggedVideo(models.Model):
    """A video that can be tagged with a category (eg. gloss, definintion, feedback)
    and a tag (eg. the gloss id) """

    objects = TaggedVideoManager()

    category = models.CharField(max_length=50)
    tag = models.CharField(max_length=50)

Could be changed to this:

class TaggedVideo(models.Model):
    """A video that can be tagged with a category (eg. gloss, definintion, feedback)
    and a tag (eg. the gloss id) """

    objects = TaggedVideoManager()

    content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE)
    object_id = models.PositiveIntegerField() # The pk/id of the object
    content_object = GenericForeignKey('content_type', 'object_id')
    tag = models.CharField(max_length=50)

• 'category' would be replaced with 'content_type'.
• 'object_id' would refer to the pk/id of the object of the selected 'content_type'.
• 'content_object' would have a relation to the object that is currently referred with 'category' and 'tag'.
• 'category' and 'tag' would be removed.

Would this kind of change be of any use?

Also if we implement #3 , don't we have to remove the 'unique_together' part?

class Meta:
    unique_together = (("category", "tag"),)

It seems that currently the filename of all uploaded files is changed to end with .mp4

@henrinie said:
We don't generate these on the server, instead our users pick a frame and upload it.
I think we would need a FileField for poster images.
The extract_frame part would need to be made optional (add a boolean to settings?)

@henrinie said:
We need to be able to upload multiple videos for one Gloss. We use GlossVideo.version to store the defined order of videos to show on gloss page. Users can arrange the videos to a desired order on the gloss page.
It seems that TaggedVideoManager would "mess" the version numbers for us if a new video is uploaded. On the other hand, it might not, the uploaded video would just show first and then it could be moved to where the user wants. Does TaggedVideoManager only update the version when a new video is added (it seems so)?