sigma88 / sigma-binary Goto Github PK

I’m encountering the issue between Sigma Binary and Distant Object Enhancement detailed here: #52

I see you resolved the issue with a DoE patch, however when DoE was taken over by The Dark Badger, it looks like he took over the version prior to your patch. I’ve reached out to him on the forums to see if he could take a look at it, but I am waiting for a reply. Is it possible for you to detail the fix you did to DoE? Can it simply be fixed with a patch?

Subject says it all

Blue Dot from Sigma Binary / Distant Object Enhancement conflict.

Spawns from craft, single-sided texture invisible when viewed from any other direction. Not collidable, static once spawned.

The issue only presents itself when there is a binary system loaded and Distant Object Enhancement is installed.

KSP 1.7.3
Kopernicus - 1.7.3.2
ModularFlightIntegrator - 1.2.6.0
Sigma Binary - 1.7.2
Distant Object Enhancement - 1.9.1.1
SigmaDunaIke

KSP.log

Systems configured by sigma binary (Duna/Ike and Plock/Karen from OPM for me) end up loosing their manned and unmanned programs from the strategia mod by nightingale. It looks like this issue was addressed in the Strategia changelog about a year ago. Nightingale hasn't replied on the KSP forums though.

Logs 'n stuff:

https://www.dropbox.com/s/o8ktbr5qid1mzxb/binary.zip?dl=0

With module manager 2.6.25 (not sure if .24 did it), I am getting numerous exceptions in the log on loading:
Example:

[LOG 06:14:18.206] [ModuleManager] Applying node Sigma/Binary/Configs/checkMaxDistance/@Kopernicus:FOR[SigmaBinary] to Kopernicus/Config/System/Kerbol System
[LOG 06:14:18.547] [ModuleManager] Exception while processing node : Sigma/Binary/Configs/checkMaxDistance/@Kopernicus:FOR[SigmaBinary]
System.NullReferenceException: Object reference not set to an instance of an object
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyTo (.ConfigNode node, System.String newName) [0x00000] in :0
at ModuleManager.MMPatchLoader.ModifyNode (.ConfigNode original, .ConfigNode mod) [0x00000] in :0
at ModuleManager.MMPatchLoader.ModifyNode (.ConfigNode original, .ConfigNode mod) [0x00000] in :0
at ModuleManager.MMPatchLoader+d__62.MoveNext () [0x00000] in :0
[LOG 06:14:18.552] [ModuleManager] @Kopernicus:FOR[SigmaBinary][@Kopernicus:FOR[SigmaBinary]]
@Kopernicus:FOR[SigmaBinary]
{
%sbMaxDistance = 113549713200
!Kopernicus,*
{
}
#@Kopernicus
{
}
@Kopernicus
{
!Body:HAS[!Orbit:HAS[#referenceBody[Sun]]]
{
}
@Body:HAS[@template[Dres]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.145
}
}
@Body:HAS[@template[Pol]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.17085
}
}
@Body:HAS[@template[Moho]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.200000002980232
}
}
@Body:HAS[@template[Bop]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.234999999403954
}
}
@Body:HAS[@template[Eeloo]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.26
}
}
@Body:HAS[@template[Jool]]
{
@orbit:HAS[~eccentricity[]]
{
eccentricity = 0.550000011920929
}
}
@Body,*
{
@orbit:HAS[#eccentricity[>0]]
{
@Eccentricity + = 1
@semiMajorAxis * = #$eccentricity$
}
@orbit
{
@semiMajorAxis - = #$/sbMaxDistance$
}
}
!Body:HAS[!Orbit:HAS[#semiMajorAxis[>0]]]
{
}
@Body,*
{
@orbit
{
@semiMajorAxis + = #$/sbMaxDistance$
}
}
}
!Kopernicus:HAS[!Body]
{
}
}

[LOG 06:14:18.570] [ModuleManager] Applying node Sigma/Binary/Configs/generateBarycenters/@Kopernicus:FOR[SigmaBinary] to Kopernicus/Config/System/Kerbol System
[LOG 06:14:18.593] [ModuleManager] Exception while processing node : Sigma/Binary/Configs/generateBarycenters/@Kopernicus:FOR[SigmaBinary]
System.NullReferenceException: Object reference not set to an instance of an object
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyTo (.ConfigNode node, System.String newName) [0x00000] in :0
at ModuleManager.MMPatchLoader.ModifyNode (.ConfigNode original, .ConfigNode mod) [0x00000] in :0
at ModuleManager.MMPatchLoader+d__62.MoveNext () [0x00000] in :0
[LOG 06:14:18.597] [ModuleManager] @Kopernicus:FOR[SigmaBinary][@Kopernicus:FOR[SigmaBinary]]
@Kopernicus:FOR[SigmaBinary]
{
@Body:HAS[@orbit:HAS[#referenceBody[Sun]]]
{
!SigmaBinary,*
{
}
}
@Body:HAS[@SigmaBinary]
{
@SigmaBinary:HAS[~name[*]]
{
name = #$../Orbit/referenceBody$$../name$
}
}
+Body:HAS[@SigmaBinary]
{
@name = SigmaBarycenter
}
}

[LOG 06:14:18.603] [ModuleManager] Applying node Sigma/Binary/Configs/generateBarycenters/@contracts:FOR[SigmaBinary] to Squad/Contracts/Contracts/Contracts
[LOG 06:14:18.896] [ModuleManager] Applying node Sigma/Binary/Configs/generateOrbits/@Kopernicus:FOR[SigmaBinary] to Kopernicus/Config/System/Kerbol System
[LOG 06:14:18.917] [ModuleManager] Exception while processing node : Sigma/Binary/Configs/generateOrbits/@Kopernicus:FOR[SigmaBinary]
System.NullReferenceException: Object reference not set to an instance of an object
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyToRecursive (.ConfigNode node) [0x00000] in :0
at ConfigNode.CopyTo (.ConfigNode node, System.String newName) [0x00000] in :0
at ModuleManager.MMPatchLoader.ModifyNode (.ConfigNode original, .ConfigNode mod) [0x00000] in :0
at ModuleManager.MMPatchLoader+d__62.MoveNext () [0x00000] in :0
[LOG 06:14:18.921] [ModuleManager] @Kopernicus:FOR[SigmaBinary][@Kopernicus:FOR[SigmaBinary]]
@Kopernicus:FOR[SigmaBinary]
{
@Body,*
{
@SigmaBinary
{
@redrawOrbit ^ = :f:F:
@redrawOrbit ^ = :A🅰️
@redrawOrbit ^ = :L:l:
@redrawOrbit ^ = :S:s:
@redrawOrbit ^ = :E:e:
}
}
+Body:HAS[@SigmaBinary:HAS[~redrawOrbit[False]]]
{
@name = SigmaOrbit
}
}

I get the following in 1.12.2 using the 1.11.1 version of SigmaBinary

ArgumentNullException: Value cannot be null.
Parameter name: key
at System.Collections.Generic.Dictionary2[TKey,TValue].FindEntry (TKey key) [0x00008] in <9577ac7a62ef43179789031239ba8798>:0 at System.Collections.Generic.Dictionary2[TKey,TValue].ContainsKey (TKey key) [0x00000] in <9577ac7a62ef43179789031239ba8798>:0
at SigmaBinaryPlugin.MapViewFixer.LateUpdate () [0x001ea] in <75d64cd1b3f149bbb23b952dd6875d0f>:0
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
Player.log