shrinish123 / guessmovie

GuessMovie is a movie Guessing game along with a search engine for your movies, TV shows, web series built using Node JS and Express Server.

• 👋 Hi, I’m @shrinish123
• 👀 I’m interested in ...
• 🌱 I’m currently learning ...
• 💞️ I’m looking to collaborate on ...
• 📫 How to reach me ...

guessmovie's Issues

Improving the search form using html css

There is no good frontend and you can easily make it look good and attractive using HTML and CSS

Browser is not informed if the requested query is not found

GuessMovie/src/app.js

Line 45 in 990d9e9

return console.log( `We were unable to find ${req.query.name}`);

In case of failing to find the requested query, error is printed to server's console but response with 404 status is not sent thy browser. So, browser keeps waiting for the response.

Improving UI for the game page

There is no good UI even for the game page so we can work even on it using HTML and CSS

add contributing.md file

• repository is missing important contributing.md file. I would like to add one which will contain all the general contributions guidelines.

Update header section

• I would like to add styling and background colour to heading and search box to improve UI.

Streaming the movie after the movie is searched for along with providing details

There are some APIs that provide movie streaming. So we need to use this to also enable movie streaming of the searched movies

Include point system for the game

Currently the game only tells you whether the answer that you gave is right is wrong. Add some point system to make the game more interesting

Create a card for displaying the movie details and styles to it

The details are already available from the server. You just need to design a card using HTML and CSS and enhance the UI.

Code of Conduct

The project is currently missing the Code of Conduct file which is important for open source project
So can I go for it @shrinish123

Add Favicon to the webpage

We need to add a favicon to the website to make it look attractive

Update readme

• I would like to add swag badges and stats badges to readme to make it look attractive.

start with node in deployment

nodemon isn't for deployment. It is a utility that speeds up the development process removing the need for restarting the server everytime we change the code.
If the server crashes due to a bug in the code, nodemon waits for change in any code. There may also occur any permission issues elsewhere because nodemon is installed inside the nodemodules of the project when deploying elsewhere. (cloud)

So, set npm start script to node and add a dev script to start with nodemon. This is a commonly used convention.

apikey should be a secret

GuessMovie/src/utils/movieSearch.js

Line 6 in 3d6e7f0

const url = 'http://www.omdbapi.com/?t='+ encodeURIComponent(movieName) + '&apikey=74648ab2'

It is not a good idea to embed api key in the code, especially when you are putting your code in public.
As the number of api calls per api calls is limited and many people using the same api key may cause problems.
It is better to store apikey as an environment variable and add instructions to developers to get their own api key. (it ain't that hard)

Refactor the code from callbacks to async await

Right now we use callbacks for the API requests. It would be great if the code is refactored using async-await