Coder Social home page Coder Social logo

Comments (9)

ADmad avatar ADmad commented on May 20, 2024

Apologies, I can fix the error by following the error message :)

from setup-php.

shivammathur avatar shivammathur commented on May 20, 2024

Yes, specify pecl in the tools input

from setup-php.

ADmad avatar ADmad commented on May 20, 2024

Is this config change required due to change in some external tool / service?

from setup-php.

shivammathur avatar shivammathur commented on May 20, 2024

No, I added support for installing various tools globally via tools input. Please see, so it made sense to refactor pecl installation in that instead of a separate input for it.

from setup-php.

ADmad avatar ADmad commented on May 20, 2024

I find it strange that you are forcing users to update their config before a deadline. Since github actions are versioned wouldn't it more prudent to simply release a new major version if your script has a breaking change? That way using using v1 wouldn't need to make any change.

from setup-php.

shivammathur avatar shivammathur commented on May 20, 2024

The change currently is not a breaking one, it is just a warning that some inputs have been deprecated and at this point old inputs will function just like they used to. I added this warning because many projects use master and changing inputs suddenly without warning will be abrupt.

The date mentioned in the warning is around the time I plan to release v2 and remove support for old inputs in that, which will be a breaking change.

from setup-php.

ADmad avatar ADmad commented on May 20, 2024

Okay, in that cause a message like The 'pecl' property will be removed in v2 would have made more sense rather than specifying a date IMHO.

from setup-php.

shivammathur avatar shivammathur commented on May 20, 2024

ok. I will make these more clear in the next release.

from setup-php.

ADmad avatar ADmad commented on May 20, 2024

Thank you.

from setup-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.