shinnn / array-includes-all Goto Github PK

Hi,

I'm trying to use this library and it's a bit of a struggle because it does not accept an empty arrays. In that case, answer should be true or false depending is programmer/user comparing

• explicitly ("everything in second array must be in first array") or
• laid back, implied ("all fine as long as no unknown keys are there in second array").

The annoyance is, I can perform array.length() checks upfront when coding Imperative programming style, but when it's Functional style, everything is chained and it's complicated and not elegant.

I'm wondering, how nice would it be to have an optional options object (where fromIndex could live too) that gave an override when input array is empty: to return true or false instead of throwing.

Please let us know your opinion.

thank you.

Hi

I just tapped this library and while checking its contents I noticed it's using istanbul, not nyc way to set up coverage calculation.

• Is there a reason for this? It looks like nyc setup is shorter.
• Out of curiosity, what do you think of switching to ava?

Feel free to close this if it is not an issue for you.

thank you.