Comments (1)
Invalid, rate decimals hard coded to correct rate decimals which is assigned to 1e18 (10 ** 18) in constructor of TradingModule.sol
here , and retrieved in getOraclePrice()
here
from 2023-10-notional-judging.
Related Issues (20)
- Jaraxxus - Approve to zero not used for lendunderlyingtokens, will affect tokens like USDT HOT 14
- bareli - Divide by zero error
- jah - a user can steal another person approved tokens HOT 1
- Jaraxxus - oracleSlippagePercentOrLimit for static trades is not checked, can be set to arbitrary value
- 0xMaroutis - No expiration deadline for trades can lead to loss of funds
- bareli - Lack of Access Control:
- Jaraxxus - UUPSUpgradeable is not initialized HOT 1
- shealtielanz - If the lend token is eth, redeemfCash will most likely revert HOT 1
- shealtielanz - An attacker can brick redemption from notional and settlements in crossCurrency vault HOT 1
- Tri-pathi - Weighted pool spot price calculation is incorrect HOT 15
- lemonmon - Spot prices calculated inside `BalancerComposableAuraVault` may not be in line with spot prices from Balancer pools due to rounding differences.
- 0xMaroutis - Hardcoded chainId Restricts Smart Contract Deployment to Arbitrum Only
- jah - wrong logic when swaping a token HOT 1
- Shubham - Hardcoding `block.timestamp` should not be used as deadline HOT 1
- ddimitrov22 - Using `block.timestamp` for swap deadline offers no protection
- ge6a - restoreVault() lacks grace period HOT 13
- 0xMaroutis - Absence sequencer status check in `_getOraclePairPrice`
- Tri-pathi - Invariant should be round down instead of round up
- shealtielanz - Unlimited slippage during `emergencyExit()` HOT 18
- lemonmon - Due to multiple issues the reinvestor may be able to steal funds from the vault.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2023-10-notional-judging.