sheetjs / js-harb

:x: Host of Archaic Representations of Books (now merged in http://github.com/sheetjs/js-xlsx )

NOTE: this has been merged into js-xlsx.

xlsx module for npm

Issues should be reported to xlsx

js-harb's Issues

error setting property of Buffer.length

I just got the following error trying to use J programatically:

$ j --version
XLS 0.7.5 ; XLSX 0.7.12 ; HARB 0.0.7
$ node --version
v5.0.0
$ node
> var j = require("j")
> j.readFile('example.xls')
TypeError: Cannot set property length of [object Object] which has only a getter

The error is being produced on cpexcel.js line 906, upon trying to set the length of a Buffer object.

mdb = new Buffer(mdl);
...
mdb.length = 2 * len;

This happens in node v4.2.1 as well, but not v0.12.4.

Global leak

Hi

I am using j in a module I am writing and when testing it complains about global leak which is coming from 20_deps.js in the bits directory. Is there no other way of exposing variables?

Thanks

Fields ending with numbers being converted to dates

Hi,

With harb 0.0.6 it seems that fields ending with a number are being converting into dates.

For example:

test.csv:

Address 1,Town
Test,Test

$ j test.csv -J
Sheet1
[{"1/1/01":"Test","Town":"Test"}]

Expected output:

Sheet1
[{"Address 1":"Test","Town":"Test"}]

The issue affects data like Address 1, but not with Address_1, Address1 or Address 1 foo. It also affects individual data items as well as column headers.

Thanks for the great work!

Wish: basic usage documentation

Currently the README punts users to read the documentation on XLS parsing to see how this CSV parser works. There's a lot of XLS-specific stuff there that doesn't apply here. There the docs show that parsing is done through a global variable named XLS. We might assume that the corresponding variable used here is named CSV, since it's not documented, but it's apparently named HARB instead.

It's details like this that make it valuable to have more complete documentation on how the CSV parsing works in this project.

Phone numbers lose leading 0

Hi,

When parsing a csv, a field containing a phonenumber such as '01234567890' loses its leading '0' to become '1234567890'.

Could we ensure that js-harb always produces strings, without any other conversions?

Thanks.

Development

Hello

I was trying to fix issue #6 on a Windows box however even though I can use 'make' on my system it is failing when running make init with following error.

D:\Modules\js-harb>make init
git submodule init
git submodule update
Submodule path 'test_files': checked out 'f5f97701f1533b5db82d2d674d362f5db680b737'
git submodule foreach git pull origin master
Entering 'test_files'
From https://github.com/SheetJS/test_files
 * branch            master     -> FETCH_HEAD
Updating f5f9770..8ab3308
Fast-forward
 Makefile                 |   3 ++-
 README.md                |  10 +++++++++-
 hyperlink_no_rels.xlsb   | Bin 0 -> 8686 bytes
 hyperlink_no_rels.xlsm   | Bin 0 -> 9347 bytes
 hyperlink_no_rels.xlsx   | Bin 0 -> 9316 bytes
 phpexcel_bad_cfb_dir.xls | Bin 0 -> 88064 bytes
 6 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 hyperlink_no_rels.xlsb
 create mode 100644 hyperlink_no_rels.xlsm
 create mode 100644 hyperlink_no_rels.xlsx
 create mode 100644 phpexcel_bad_cfb_dir.xls
git submodule foreach make
Entering 'test_files'
make[1]: Entering directory `d:/Modules/js-harb/test_files'
svn co http://svn.apache.org/repos/asf/poi/trunk/test-data/spreadsheet/ apachepoi
process_begin: CreateProcess(NULL, svn co http://svn.apache.org/repos/asf/poi/trunk/test-data/spreadsheet/ apachepoi, ...) failed.
make (e=2): The system cannot find the file specified.
make[1]: *** [apachepoi] Error 2
make[1]: Leaving directory `d:/Modules/js-harb/test_files'
Stopping at 'test_files'; script returned non-zero status.
make: *** [init] Error 1

Any help would be appreciated.

export socialcalc formulas to excel

Ethercalc fails to export formulas to excel.

2 issues are involved

1. This fix is required mcsf/js-xlsx@d439645
2. SheetJS/js-harb does not support exporting of socialcalc formulas
   the formula would need to be copied into the object.

Fix
I am happy to fix this - but with https://github.com/SheetJS pull requests are being ignored - Abandoned?

use https://github.com/mafintosh/csv-parser for csv parsing

faster than babyparse

SocialCalc: \c \b \n are unescaped

Minimal example, round-tripping CSV through SocialCalc:

echo 'c:\>dir,cls' | j - -E | j -

Result is c\c\b>dir,cls while it should be back to c:\>dir,cls.

PRN files

Any plans for Lotus file support?