Compatability issues with MoreEnchantments about materialisation

[John-Paul-R]

Update: I'm fairly certain that my proposed fix will not work, as the MaterializationUtils.getDurability() method I referenced is not an instance method of the ItemStack class (the variable tool is of type ItemStack). Perhaps this method should be added to items.MaterializedMiningTool (or classes that implement it) directly? Edit: I misunderstood how those classes operate.

[shedaniel]

I can try to go over it tomorrow.

[John-Paul-R]

Upon testing again, I found that while the exact issue mentioned above no longer occurs, a new one has been introduced. Veinminer now properly activates for Materialisation pickaxes, but the way that the durability is set after the action is complete is broken. The durability (mt_durability tag) is set to the difference between the tool's durability value at the time it broke the block and its max durability. Ex: if you have a materialized iron pickaxe (max durability 250) at durability 240, and veinmine with it, its durability will then be set to 10. This results in instant pickaxe breakage if veinmining occurs at max durability.

I believe this may be in some way caused by the fact that MoreEnchantments calls the method: ItemStack.damage(), which does not have an implementation in Materialisation's durability system, but I am not sure.

[John-Paul-R]

This issue seems to be resolved in the latest update.

[shedaniel]

Yep it should be