shawnzhu / artifacts-v2 Goto Github PK

Now artifact server needs a single table in a PostgreSQL database. It can use the current PostgresSQL database in a Travis CI enterprise deployment or another new database.

/cc @meatballhat @joshk

follow up #12 (review)

I've made travis-build to provide an addon to enable travis-worker uploading artifacts into artifacts server via a JWT token. There're two options in my mind to expose artifacts meta info to travis-web:

1. add new api endpoint in travis-api like /api/jobs/<job-id>/artifacts so Travis web can pick up artifacts meta info via existing authentication of travis-api. Then the architecture design is, travis-api will serve as gateway of artifacts server for all API traffic.
2. add the authentication method used by travis-api today to this artifacts server so that travis-web can redirect user to artifacts server directly. Then the artifacture design is, artifacts-server needs to access Redis and/or Postgres database of Travis CI.

@josh @meatballhat @rkh comments?

This may be required when repo or PR owner decide to remove an uploaded artifact file.

it would be ideal not to have to store https://github.com/shawnzhu/artifacts-v2/blob/master/model/artifact.go#L8
and instead construct the object key based on a pattern
this way we don’t tie any of the implementation to s3

Requirement

Need to remove all artifacts uploaded before restarting

Follow-up of review comments of #10

• uses gorilla mux for routing - #10 (comment)
• uses negroni for middleware handling - #10 (comment)

the first was https://github.com/shawnzhu/artifacts-v2/blob/master/model/artifact.go#L6
this should be JobId instead of BuildId, as the artifacts will be mapped to jobs

Today

Now I use HS256 where it uses a single shared key to sign and verify JWT token signature. it is simple but requires configuration option on both travis-ci/travis-build and this feature.

Proposal

Uses RS256 where it uses an RSA private key (available in the context of a Travis build) to sign JWT token, artifacts server will use RSA public key (available when querying Travis Postgres database) to verify JWT token signatures.

The implementation will be more work but no configuration required on neither travis-build nor artifacts.

/cc @meatballhat

Just keep new meta info for an artifact file.

Run travis-artifacts on GCE so that we can start to experiment this feature in Travis CI first.

Including:

• remove hard coded configuration option in code - E.g., #12
• continuous delivery process via Travis CI - #15
• uses a CLI framework to manage configuration - #13