sharplispers / cxml-stp Goto Github PK

find-child accepts from-end, start, end, and key args and silently ignores them.

When one does:

(ql:quickload :cxml-stp-test)

one gets:

4 out of 246 total tests failed: TEXT.SERIALIZE, 
   ELEMENT.ADD-EXTRA-NAMESPACE.4, ELEMENT.COPY.7, ELEMENT.BASE-URI.

Notice I said 5, not 4, as pull request #1 fixes the with-attributes test, which still fails on the master branch.

Fixed:

• TEXT.SERIALIZE
• ELEMENT.ADD-EXTRA-NAMESPACE.4
• ELEMENT.COPY.7
• ELEMENT.WITH-ATTRIBUTES
• ELEMENT.BASE-URI

We probably shouldn't use check-type here as it expects a place and nth-child isn't a place. Of course we could make it so, but I don't think it is at the moment, hence the error.

There's a (declaim (optimize (debug 2))) form at the top of node.lisp. I think this is an attempt to ensure that tail calls are optimized so that we don't blow the stack. The problem is that this doesn't take effect when the compiler policy is restricted and may lead to globally setting the optimization forms (the spec says its undefined if this happens).

Thoughts on how to fix this?