The closure-common from sharplispers

Verbose ASD loading

Lines 18 to 48 in 8746120

    
           (progn 
        
             (format t "~&;;; Checking for wide character support...") 
        
             (force-output) 
        
             (flet ((test (code) 
        
           	   (and (< code char-code-limit) (code-char code)))) 
        
               (cond 
        
                 ((not (test 50000)) 
        
                  (format t " no, reverting to octet strings.~%") 
        
                  #+rune-is-character 
        
                  (error "conflicting unicode configuration.  Please recompile.") 
        
                  (pushnew :rune-is-integer *features*)) 
        
                 ((test 70000) 
        
                  (when (test #xD800) 
        
           	 (format t " WARNING: Lisp implementation doesn't use UTF-16, ~ 
        
                                but accepts surrogate code points.~%")) 
        
                  (format t " yes, using code points.~%") 
        
                  #+(or rune-is-integer rune-is-utf-16) 
        
                  (error "conflicting unicode configuration.  Please recompile.") 
        
                  (pushnew :rune-is-character *features*)) 
        
                 (t 
        
                  (format t " yes, using UTF-16.~%") 
        
                  #+(or rune-is-integer (and rune-is-character (not rune-is-utf-16))) 
        
                  (error "conflicting unicode configuration.  Please recompile.") 
        
                  (pushnew :rune-is-utf-16 *features*) 
        
                  (pushnew :rune-is-character *features*))))) 
        
           #-rune-is-character 
        
           (format t "~&;;; Building Closure with (UNSIGNED-BYTE 16) RUNES~%") 
        
           #+rune-is-character 
        
           (format t "~&;;; Building Closure with CHARACTER RUNES~%")

This codeblock contributes to (IMO unnecessarily) verbose Quicklisp loads of closure-common, for instance:

To load "foo-system":
  Load 1 ASDF system:
    foo-system

; Loading "foo-system"
.
;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points.
 yes, using code points.
..
;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points.
 yes, using code points.
;;; Building Closure with CHARACTER RUNES
...............................................
...................

Is it possible/desired to remove the FORMAT calls altogether?

`:fill-ptr` vs. `:fill-pointer`

Hi,

would you mind changing the fill-ptr slot in xstream.lisp to fill-pointer?
I'm asking because :fill-ptr comes up in auto-completion before :fill-pointer, and that's a bit annoying ;)

Thank you!

DEFTYPE SIMPLE-ROD is imprecise

closure-common/utf8.lisp

Line 11 in e3c5f5f

(deftype simple-rod () '(simple-array rune))

Shouldn't this be (simple-array rune (*)) to prevent multidimensional arrays from pretending to be simple-rods?

sharplispers / closure-common Goto Github PK

closure-common's People

Contributors

Watchers

Forkers

closure-common's Issues

Verbose ASD loading

`:fill-ptr` vs. `:fill-pointer`

DEFTYPE SIMPLE-ROD is imprecise

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	(progn
	(format t "~&;;; Checking for wide character support...")
	(force-output)
	(flet ((test (code)
	(and (< code char-code-limit) (code-char code))))
	(cond
	((not (test 50000))
	(format t " no, reverting to octet strings.~%")
	#+rune-is-character
	(error "conflicting unicode configuration. Please recompile.")
	(pushnew :rune-is-integer features))
	((test 70000)
	(when (test #xD800)
	(format t " WARNING: Lisp implementation doesn't use UTF-16, ~
	but accepts surrogate code points.~%"))
	(format t " yes, using code points.~%")
	#+(or rune-is-integer rune-is-utf-16)
	(error "conflicting unicode configuration. Please recompile.")
	(pushnew :rune-is-character features))
	(t
	(format t " yes, using UTF-16.~%")
	#+(or rune-is-integer (and rune-is-character (not rune-is-utf-16)))
	(error "conflicting unicode configuration. Please recompile.")
	(pushnew :rune-is-utf-16 features)
	(pushnew :rune-is-character features)))))

	#-rune-is-character
	(format t "~&;;; Building Closure with (UNSIGNED-BYTE 16) RUNES~%")

	#+rune-is-character
	(format t "~&;;; Building Closure with CHARACTER RUNES~%")