shama / atlaspack Goto Github PK

Would be nice to have it as a separate module that doesn't need canvas.

If I pack a rect or a literal, I can't find it again using index.

var atlaspack = require('atlaspack');
var Rect = atlaspack.Rect;

var atlas = atlaspack(100, 100);

var rect = new Rect(0, 0, 10, 10);
rect.name = "from a rect";
atlas.pack(rect);

atlas.pack({x:0, y:0, w:10, h:10, name:"literal"});

console.log(atlas.index()); // []
console.log(atlas.uv()); // {}

When I use pack() I can fix it manually by doing packed = pack(...); packed.rect.name = "somename" but I can't do that if I use expand().

Hi @shama. Thank you for sharing this great library.

I've rewritten atlaspack in TypeScript link because of my opinionated passion for type safety :) Just wanted to let you know how your code looks like in TypeScript.

By the way, I've learned a lot from your code around voxel.js world. Thank you for your contribution again!

I tried to pack every 3 words from lorem ipsum and run into weird layout issue:

Despite lots of white space on the left i failed to pack 2 short sentences:

Tried same rects with the original binpack with the same result

Data i'm using

[{"width":175.625,"height":30},{"width":194.521484375,"height":30},{"width":201.19140625,"height":30},{"width":202.333984375,"height":30},{"width":187.8515625,"height":30},{"width":166.7578125,"height":30},{"width":152.275390625,"height":30},{"width":127.841796875,"height":30},{"width":182.32421875,"height":30},{"width":114.4921875,"height":30},{"width":201.181640625,"height":30},{"width":120.048828125,"height":30},{"width":253.4375,"height":30},{"width":166.71875,"height":30},{"width":143.3984375,"height":30},{"width":153.388671875,"height":30},{"width":210.1171875,"height":30},{"width":282.3828125,"height":30},{"width":170.078125,"height":30},{"width":177.861328125,"height":30},{"width":106.708984375,"height":30},{"width":196.77734375,"height":30},{"width":163.41796875,"height":30},{"width":197.87109375,"height":30},{"width":173.427734375,"height":30},{"width":170.087890625,"height":30},{"width":177.861328125,"height":30},{"width":154.53125,"height":30},{"width":253.4375,"height":30},{"width":214.53125,"height":30},{"width":132.28515625,"height":30},{"width":146.728515625,"height":30}]

Have you ever encountered any issues like that?

With ES6 adoption growing fast it's nice to have the original source. The current approach results in errors like the following in webpack:

WARNING in ~/atlaspack/index.js
Critical dependencies:
1:440-447 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
@ ~/atlaspack/index.js 1:440-447

May I suggest moving the umd build to dist/atlaspack.js instead?

Related to #8

currently the docs for atlas.uv() state:

var uvmap = atlas.uv();
/* {
              TOP   RIGHT  BOTTOM  LEFT
  'name':  [ [0,0], [1,0], [1,1], [0,1] ],
} */

When I think of a quad, I think of four pairs of points, so instead of TOP, RIGHT, BOTTOM, and LEFT, I would expect something more like TOP-LEFT, TOP-RIGHT, BOTTOM-LEFT, BOTTOM-RIGHT.

hi - is it possible to remove a rectangle ?

Returns a flat array of rect positions for an index. Also add name to Rect and read id || name from images to set.

@shama Would you mind creating a new NPM release with #12 ?

Thanks for the tool. Great work.

Noticed this while debugging.. atlas.uv() appeared to return an empty array [], even though it had properties set for each of the textures (as expected). pack() sets _uvcache to an empty array:

this._uvcache = [];

although earlier in the Atlas constructor it is set to a new object:

this._uvcache = Object.create(null);

uv() uses the .length property, presumably intending an array:

if (self._uvcache.length > 0) {
  return self._uvcache;
}

but the same function sets self._uvcache[atlas.rect.name].

Should _uvcache really be an array? This could potentially cause problems with texture names clashing with Array properties: