shakir85 / terraform-modules Goto Github PK

This rule allows all users to have privilege escalation when using sudo for all commands. This is not a good practice.

Suggested solution is to user TF variable username which is already a requirement for the module:

         sudo: ${var.username}=(ALL) NOPASSWD:ALL

Put the following vars in a list, then access the list's element via its index:

  cloud_image_storage = "sdc"
  cloud_image_name      = "debian-12-generic-amd64.qcow2.img"

Add the output block to the docs. Use terraform-doc

Add TF output block to print the default password var.temp_user_password for convenience. Also, add an info message that the password will be forced to change on the first login.

Summary

The current Proxmox/VM module defaults to the qmue CPU type, which is the default in PVE. In some cases, we need to change that to support certain applications that don't work with this architecture.

For example, MongoDB version 5+ will fail to work on a VM with the CPU type set to qmue:

WARNING: MongoDB 5.0+ requires a CPU with AVX support, and your current system does not appear to have that!
  see https://jira.mongodb.org/browse/SERVER-54407
  see also https://www.mongodb.com/community/forums/t/mongodb-5-0-cpu-intel-g4650-compatibility/116610/2
  see also https://github.com/docker-library/mongo/issues/485#issuecomment-891991814

Proposed solution

Add the optional feature to set the CPU architecture cpu.type:
https://registry.terraform.io/providers/bpg/proxmox/latest/docs/resources/virtual_environment_vm#host

Currently impacted VMs

• logger - Graylog VM

Since this file will always be overwritten by the module when called, use a unique name to avoid overwriting a snippet with the same name the user downloaded or used outside the Terraform module.

Suggest: reponame + path-to-module: e.g. shakir85-terraform-modules-proxmox-vm-cloudinit.yml

Output when deploying a new vm

╷
│ Warning: the existing file "sdd:snippets/cloud-config.yaml" has been overwritten by the resource.
│
│   with module.crap2.proxmox_virtual_environment_file.cloud_config,
│   on .terraform/modules/crap2/proxmox/vm/main.tf line 83, in resource "proxmox_virtual_environment_file" "cloud_config":
│   83: resource "proxmox_virtual_environment_file" "cloud_config" {
│
╵