sfmict / mountsjournal Goto Github PK

Environment

• Addon version: 10.2.17
• WoW version: 10.2

Steps to reproduce

Relogin, or just /rl, mount list is lost.

Expected Behaviour

mount list should be saved

Actual Behaviour

mount list is lost. Everything start from an empty list

Debug Output

No debug or error

Screenshots

--

Environment

• Addon version: 10.1.12
• WoW version: 10.1.7.51754

To be honest, I don't really know. I think it's when I mount up, but not sure. It seems random to me.

It's random.

It's random.

12x [ADDON_ACTION_BLOCKED] AddOn 'MountsJournal' tried to call the protected function 'MultiBarRightButton1:SetShown()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function SetShown' [string "@FrameXML/ActionBar.lua"]:194: in function UpdateShownButtons'
[string "@FrameXML/ActionButton.lua"]:346: in function UpdateAction' [string "@FrameXML/ActionButton.lua"]:799: in function OnEvent'
[string "@FrameXML/ActionButton.lua"]:196: in function <FrameXML/ActionButton.lua:193>

Environment

• Addon version: Latest
• WoW version: Retail 10.2.7

Desired functionality

A "Family" filter

I use Mount Journal Enhanced alongside your addon, as MJE has a "Family" filter that is very useful at times. The downside is that MJE "hidden" and MJ "hidden" aren't the same, so I have to maintain two lists with hidden mounts to declutter my list. If MJ had a family filter that worked like MJE's did, I would be able to do all of my mount stuff with just your addon.

Mounts Journal is by far the most superior mount addon I've used, and I love it. I just have two requests.

1. Target mount copy
   If you target someone and click on the macro, it will try to copy the mount they are riding.
2. Add the second herbalism mount, Mechanized Lumber Extractor, and randomly call one of the two if both are owned and the Herbalism flag is checked.

Thank you!

Environment

• Addon version: 8.3.1
• WoW version: 8.3

Steps to reproduce

Open Guild UI,
Choose a member,
Try and change their rank.

Expected Behaviour

Their rank would change.

Actual Behaviour

Blocked UI Action dialogue appears.

Debug Output

1x [ADDON_ACTION_FORBIDDEN] AddOn 'MountsJournal' tried to call the protected function 'SetGuildRankOrder()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function SetGuildRankOrder' [string "@Blizzard_Communities\GuildRoster.lua"]:174: in function func'
[string "@FrameXML\UIDropDownMenu.lua"]:895: in function `UIDropDownMenuButton_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

Screenshots

N/A

to have mounts linked in chat be directed to mount journal would be a nice feature

Environment

• Addon version: 8.3.2
• WoW version: 8.3

Steps to reproduce

Create multiple profiles using the dropdown , i used copy current profile option
Set different favourites on each profile
switch between and you will notice the favorites save across all profiles , but the flying land and under water icons change with profile

Expected Behaviour

The favourites should be saved per profile and change when switching profiles in the same fashion as the fly.land underwater icons do

Actual Behaviour

the favorites save to every profile instead of the currently selected profile

Hello would it be possible to allow us to have mounts summon at 0.001% for example?

currently, its tied to a minimum of 0.1%

3x [ADDON_ACTION_FORBIDDEN] AddOn 'MountsJournal' tried to call the protected function 'CastSpell()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `CastSpell'
[string "@FrameXML/SpellBookFrame.lua"]:701: in function <FrameXML/SpellBookFrame.lua:648>

not sure what I was doing to case this or what it was actually doing but I thought I would share

Not sure if this is the right place to put this, but it seems correct. I noticed that Dragonriding mounts are treated as just another mount by the addon randomizer when in Dragonflight zones, and that gets pretty obnoxious in practice. So I went and added in a filter to my install of it to exclude non-dragonriding mounts in dragonflight zones. It relies on zone UI ID right now, because I couldn't find any better way to tell if dragonriding is available, but it seems to be fully functional and doesn't interfere with other functionality of the addon. The code is below:

Modification to Mounts.lua, starting at line 642:

do
	local usableIDs = {}
	function mounts:summon(ids)
		local isInDragonridingZone = isInDragonridingZone();
		local weight = 0
		for mountID in next, ids do
			local _,_,_,_, isUsable,_,_,_,_,_,_,_,isDragonriding = C_MountJournal.GetMountInfoByID(mountID)
			if ( isInDragonridingZone ) then 
				if( isDragonriding ) then
					weight = weight + (self.mountsWeight[mountID] or 100)
					usableIDs[weight] = mountID
				end
			else
				if isUsable then
					weight = weight + (self.mountsWeight[mountID] or 100)
					usableIDs[weight] = mountID
				end
			end
		end
		if weight > 0 then
			for i = random(weight), weight do
				if usableIDs[i] then
					C_MountJournal.SummonByID(usableIDs[i])
					break
				end
			end
			wipe(usableIDs)
			return true
		else
			return false
		end
	end
end

function isInDragonridingZone()
	local mapId = C_Map.GetBestMapForUnit("player")
	return (mapId == 2022 or mapId == 2023 or mapId == 2024 or mapId == 2025 or mapId == 2026 or mapId == 2093 or mapId == 2112 or mapId == 2134 or mapId == 2135)
end

automatically summon Corridor Creeper mount when you are in the maw

Feature Request,

Please introduce having to "Try to copy target's mount" overwrite "Use Magic Broom" I use the Halloween broom for mobile though wish to copy target mounts.. Maybe if a target is set have it ignore the broom prio?

Environment

• WoW version: WotLK Classic 3.4.3

Now that WoTLK Classic (version 3.4.3) has a Collections User Interface like Retail, could you port MountsJournal to WotLK Classic? (I know about the existence of MountsJournal_Classic, but MountsJournal would fit better with Blizzard's new UI.)

Thank you so much.

Environment

• Addon version: 10.0.4
• WoW version: 10.0.2

It would be nice if there was an option to summon the dragonriding mount on DF zones and not the other ones.

Environment

• Addon version: v9.1.2
• WoW version: 9.1.0
  The buttons to make a mount be summoned by the addon are gone. (see marked square in screencap)

A macro using:

/click [btn:1] MountsJournal_Mount

...is no longer performing any action (it was working in the previous version I had installed, which I believe was alpha 3).

/mount

...works fine, but doesn't accept a modifier, making my [btn:2] command for my repair mount fail.

Environment

• Addon version: 10.0.3
• WoW version: 10.0.3

Steps to reproduce

As above.

Expected Behaviour

Selected mount summoned

Actual Behaviour

Nothing happens

Debug Output

No errors.

Screenshots

Would it be possible to allow a modifier to change behavior?

Specifically, I'd like the ability to right-click for Grand Expedition Yak (or Ctrl-click, etc)

Environment

• Addon version: 9.0.9
• WoW version: 9.0.2

Steps to reproduce

Enter De Other Side Instance
Summon mount

Expected Behaviour

Should summon ground mount as flying is not available

Actual Behaviour

Summons flying mount

This appears to be working correctly in other outdoor instances (ie plaguefall, Opening area of Theater of Pain, Necrotic Wake) , I have only noticed this happening in De Other Side
Perhaps this instance is not classified properly in region detection ?

2x MountsJournal\config\About.lua:104: attempt to index global 'Settings' (a nil value)
[string "@MountsJournal\config\About.lua"]:104: in main chunk

Locals:
addon = "MountsJournal"
L =

Configuring zone flags.

Setting up relations to use one list of mounts in different zones."
Add tag = "Add Tag"
SecondMountTooltipTitle = "If the modifier is hold or “%s 2” is used:"
Run = "Run"
Swim = "Swim"
Shown: = "Shown:"
Reverse Sort = "Reverse Sort"
WaterWalkFlagDescription = "Used to configure some classes."
Select all mounts by type in selected zone = "Select all mounts by type in the selected zone"
factions = "Factions"
NoPetInRaid = "Do not summon battle pet in raid group"
With multiple models = "With only multiple models"
Set current filters as default = "Set current filters as default"
PET_4 = "Without Pet"
CHARACTER_CLASS_DESCRIPTION = "(character settings override class settings)"
UseUnderlightAnglerDescription = "Use Underlight Angler instead of underwater mounts."
Fly = "Fly"
UseMagicBroomTitle = "Use Magic Broom"
Random available mount = "Random available mount"
Are you sure you want to delete profile %s? = "Are you sure you want to delete profile "%s"?"
Restore default filters = "Restore default filters"
ConfigPanelTitle = "Global settings"
Default = "Default"
MOUNT_TYPE_1 = "Flying"
SecondMountTooltipDescription = "If you are in water then will be summoned non-waterfowl mount.

If you are on land and you can fly then will be summoned ground mount."
Favorites First = "Favorites First"
PET_3 = "With Pet"
CopyMountTarget = "Try to copy target's mount"
UseHerbMounts = "Use Mount for Herbalism"
sources = "Sources"
UseRepairMountsDescription = "If the durability of at least one item is less than the specified percentage, the selected mount will be summoned."
Water Walking = "Water Walking"
UseHerbMountsOnZones = "Only in Herb Gathering Zones"
CreateMacroTooltip = "The created macro is used to summon the selected mounts."
= (equal to) = "= (equal to)"
A profile with the same name exists. = "A profile with the same name exists."
ListMountsFromZone = "Use list of mounts from zone"
Initial x-axis accseleration = "Initial X-axis Accseleration"
CLASS_USEWHENCHARACTERFALLS = "Use the %s when the character falls"
Fly backwards = "Fly backwards"
HerbGatheringFlagDescription = "Used to configure use of Mount to Herbalism."
Profile settings = "Profile settings"
Enable Acceleration around the X-axis = "Enable Acceleration around the X-axis"
DRUID_USEDRUIDFORMSPECIALIZATION = "Return a specialization form"

(more than) = "> (more than)"
Normal mount summon = "Normal mount summon."
Hidden by player = "Hidden by player"
CLASS_USEWATERWALKINGSPELL = "Use the %s when summoning ground mount"
CLASS_USEONLYWATERWALKLOCATION = "Use only in water walk zones"
ZoneSettingsTooltip = "Zone settings features"
Y-axis accseleration = "Y-axis Accseleration"
Are you sure you want to delete animation %s? = "Are you sure you want to delete animation "%s"?"
By Specialization = "By Specialization"
In flyable zones = "In flyable zones"
< (less than) = "< (less than)"
Auto add new mounts to selected = "Auto add new mounts to selected"
Herb Gathering = "Herb Gathering"
Create = "Create"
Profiles = "Profiles"
Enable Flags = "Enable Flags"
Zones settings from default profile = "Zones settings from default profile"
Walk = "Walk"
Pet binding from default profile = "Pet binding from default profile"
Current Location = "Current Location"
UseMagicBroomDescription = "When "Hallow's End" event is active, if you have a "Magic Broom", it is used."
Are you sure you want %s? = "Are you sure you want "%s"?"
Click opens in = "Click opens in"
Modifier = "Modifier"
Collected: = "Collected"
With all tags = "With All Tags"
Ground Mounts Only = "Ground Mounts Only"
Map / Model = "Map / Model"
author = "Author"
PET_1 = "With Random Favorite Pet"
Class settings = "Class settings"
Localization Transl