sfackler / futures-state-stream

futures-state-stream

Documentation

A version of the futures crate's Stream which returns state on completion

License

Licensed under either of

• Apache License, Version 2.0, (LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0)
• MIT license (LICENSE-MIT or http://opensource.org/licenses/MIT)

at your option.

Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions.

futures-state-stream's Issues

Expecting fold() to yield (Accumulator, State)

I was trying to use StateStream::fold() just now. I have a StateStream that yields protocol responses from the network and has the underlying transport as state. However, the current implementation of fold() seems to want to subsume the State into the accumulator. If fold instead yielded the complete accumulator and state together, the next step in the future chain could always do the same thing that's now done in the done argument function.

Does that make sense? It could be implemented as a fold_state(), but since (I think) the old behavior is trivially available, it might make more sense to just replace fold().

Nothing implements StreamExt

I tried to convert futures::stream::Stream to futures_state_stream::StateStream but found out that into_state_stream cann't be applied for Stream.
Should StreamExt be implemented for any implements Stream like FutureExt is implemented for any implements Future

What to do if I don't have State on Err?

So I just tried to update tokio-imap to 0.2, and ran into issues: in https://github.com/djc/tokio-imap/blob/master/src/client/mod.rs#L74, I have a poll method that's supposed to (a) poll the send future to get the transport back, (b) poll the transport for responses to the command I just sent and return them as StreamEvent::Next, and (c) when the final command response is received, emit StreamEvent::Done. However, if the code in (a) fails (on line 85), what am I supposed to do with the new API?

StateStream doesn't implement then, and_then and or_else methods.

Should be then, and_then and or_else methods implemented for StateStream or they was removed for a reason?

Could this crate help Kabuki?

with carllerche/kabuki#5