sf-wdi-labs / shared_modules Goto Github PK

Would like comments on:

I’m working on the iterators stuff right now. I’m considering converting everything from:

var numbers = [1, 4, 9];
var doubles = numbers.map(function(num) {
  return num * 2;
});

to

var numbers = [1, 4, 9];
function doubler(num) {
  return num * 2;
}

var doubles = numbers.map(doubler);

At least initially because I don't think they're really comfortable with those anonymous functions yet. Although I think maybe @bgveenstra may have used them briefly (wed).

thoughts?

• should be own repo if providing starter code
• specify name of database to create to match code from readme

Model a Game with OO (happens to be proj 0 games…) (CF)

Express Docs, REST reading (CF)

OOP Readings (JC)

• Original vs. derived work
  • Citing stack-overflow/blog copy-pasta with a comment
  • Mentioning collaborators with @github shoutouts
• etc

Nearly completed at: https://github.com/SF-WDI-LABS/letterCount

It would be nice if we (mostly) only needed to look at Pull Requests to discuss/review them.

I suggest that instead of creating an issue, we can simply "stub" a branch by making a small change ( perhaps stubbing a folder with a .gitkeep file). That way our conversation all happens in one place.

This would be especially nice for homeworks and lectures.

@bgveenstra @tgaff @justincastilla @jlopker @cofauver

paperclip instructions need a rewrite after changes in configuration needs

HW / spotify?

add suggestions here

https://github.com/SF-WDI-LABS/shared_modules/blob/master/01-front-end-basics/js-object-primitives/27-28/README.md

The image link on this page is dead :-(

the link to how to fork is broken

CRUD/Query Method Reading (best of mongoose docs) (CF ask BV/NA)

@bgveenstra @nathanallen

Refactor & Debug Weekend Lab?, HTTP Readings? (TG)

see #16 (comment)

We previously looked at 26's code and thought it was better organized. They have controllers for each route and use express.Router. We also considered that this might be overly complicated especially on the first day.

Please discuss, should we:

1. Stick with our traditional approach of all the routes in server.js. See also this lab solution
2. Move immediately to putting each route in controllers and using express.Router
   see an example of that here. ⚠️ Note that this requires re-writing pretty much all of our Node stuff.
3. Delay this and start with the traditional approach, later (maybe the next day with Todo Lab, or the next week with Tunely) switch to Router and controllers.
4. Something even better that you'll explain to us here. ❔
5. Juliana suggested what I'm calling a namespace-less mountable app (no router) She also suggested calling the files resources instead of controllers:

module.exports = function(app) {
​
  app.get('/api/admin/unconfirmed-users', auth.ensureAuthenticated, auth.ensureAdmin, function (req, res) {
    User.find({ confirmedAt: null }, '+email').exec(function (err, users) {
      res.send(users)
    })
  })
}

Please note that this issue is time-sensitive. Next week's lessons are already due and last-minute changes are bad news bears. 🐻

Paperclip instructions can (and should) point to general secret key hiding documentation (currently how-to/store-secrets-in-rails-using-env-vars.md).

Add homework suggestions here

Expecting validation in user class, ie: http://stackoverflow.com/questions/4697536/validators-password-confirmation

generalassemb.ly no longer has jQuery

add suggestions here

Express build drills

Leaning toward 25, they're all VERY similar:
https://github.com/SF-WDI-LABS/shared_modules/tree/master/01-front-end-basics/js-control-flow/25

One conceivable sequencing issue: We won't have taught chrome dev console yet, but the exercises require it.

HTTP, HTML Forms & Query Params (TG/NA)