seungkang / oki Goto Github PK

When parsing an ELF with -R, oki includes single quotes and backslashes in the output to help write shell scripts. For example:

$ oki -R rizin
-u 'r:/usr/local/lib/librz_util.so.0.7' \
-u 'r:/usr/lib/libm.so.10.1' \
-u 'r:/usr/lib/libutil.so.17.0' \
(...)

It would be nice if we could make this behavior optional so it does this instead:

$ oki -R rizin
-u r:/usr/local/lib/librz_util.so.0.7
-u r:/usr/lib/libm.so.10.1
-u r:/usr/lib/libutil.so.17.0
(...)

The latter format makes it easier to create shared config files that can be used in multiple shell scripts. For example:

#!/bin/sh

set -u

work_dir="${OKI_WORKDIR:-${HOME}/memla}"

oki \
  -p stdio \
  (...)
  -u rwc:/tmp \
  -u r:/usr/libexec/ld.so \
  -u r:/usr/lib \
  -u r:/usr/lib/libc.so.97.0 \
  $(/bin/cat /tmp/rules-example.txt) \
  -- rizin $@

... where /tmp/rules-example.txt contains:

-u r:/usr/local/lib/librz_util.so.0.7
-u r:/usr/lib/libm.so.10.1
-u r:/usr/lib/libutil.so.17.0
(...)

Perhaps this can even be the default behavior and the current behavior can be optional?

When using -R to generate unveil rules for dependent libraries, program returns an error if the imported library is a file path. Not sure how common it is for an imported library to be a file path but it occurs with the rizin package.

Example:

$ oki -R rizin
fatal: failed to get ELF dependencies unveil paths - imported library contains / - /usr/local/lib/<some-library>

Possible Fixes

Adding support for libraries that are file paths, so long as they are prefixed with the paths in the runPaths variable. We need to call filepath.Clean() and filepath.Abs() on both the runPaths variable and the imported library if it is a file path.

Ran -R on git and returned with error:

$ oki -R git
fatal: failed to get ELF dependencies unveil paths - could not find library: "libiconv.so.7.1" - searched in ["/usr/lib"]

Library is in /usr/local/lib.

$ find /usr -type f -name libiconv.so.7.1
/usr/local/lib/libiconv.so.7.1

Possible Fixes

We want to check if /usr/local/lib is in git's DT_RUNPATH or any of its libraries' DT_RUNPATH.
If it isn't, we should consider checking there by default.
We should review how ld.so works and read manual page. (man ld.so)