sethdusek / define Goto Github PK

I get this error whilst using the --audio flag:

bash: play: command not found

I suggest using mplayer, which can fetch the audio file by itself without the need of wget.
If mplayer is out of the question, fix the package dependencies.

The program prints out this error when the searched string has not been found on Wordnik.

Traceback (most recent call last):
  File "/usr/bin/define", line 24, in <module>
    print(rem[i].upper() + ": \n" + client.getDefinitions(rem[i])[0].text)
TypeError: 'NoneType' object has no attribute '__getitem__'

Hiya, trying to (well I did lol) package this for aur. Can see it here https://aur.archlinux.org/packages/whatis-git/

But it seems to conflict with any existing package that ALOT of people most likely have installed. (whatis from man-db package)

https://www.archlinux.org/packages/core/i686/man-db/files/

Is there any other names you would consider being ok to use for the "executable" name?

This issue is, actually, #16 , #22 and #23 but they were closed by the childish maintainer of this project. No need to add a proper description, just read those, other than #23 which was changed by the aforementioned childish maintainer.

In this code, it is assumed that the user wants the English definition. Perhaps this could be fixed by using the system dictionary?

Hi, I've already opened 3 issues but am not satisfied, even though define supports local wordnet and also gcide for the dict protocol.

This software, needlessly, uses a website to define words. This is a privacy issue, for many obvious reasons. The first of which is a simple MITM attack, and the worst of which is data collected by the service used itself. There are, at least, access logs containing the users' IP addresses, and SethDusek5, himself, says that stats are collected on the words users define.

This also brings up issues where this project is wasting bandwidth, making HTTP requests when you could obviously just look for the definition in a file easily.

Almost all words are not limited to one definition. And usually the Wordnik web-interface shows a few of them alongside with the corresponding part of speech. It would be nice for this program to do the same.

I know this has been referenced in a previous issue: #5 however, the fix was add a dependency to an Arch package. For people installing this from source or people using operating systems where play is not available, that isn't an adequate fix.

Getting sound to work on every platform is a nightmare (I just tried :D ) I guess that's why libraries exist..

Here's a good page that lists a few external dependencies we could use to play sounds programatically.

https://wiki.python.org/moin/PythonInMusic

Your current code has API keys for services used, you should either remove all such items and services. This application is infringing on the rights of users. People want to be able to freely look up a term in a dictionary of their language. The best way to do this is to use the dictionaries already present on the system.

Do not use services that log requests made by users, and, certainly, not with your API keys. Your users are not you.