servusdei2018 / tankistonline Goto Github PK

Feel free to discuss the roadmap for Tankist right here.

The procedure on_draw() doesn't account for playSound = False, thus, it tries to access the is_playing() method of an un-existant object.

@window.event
def on_draw():
	window.clear()
	
	player_sprite.draw()
	
	for enemy in enemies:
		
            enemy.draw()

	    if bool(theme.is_playing()) == False: #Problematic code
	    #assumes that theme exists
	
		theme.play()

The server-side code needs to be updated to Python 3.

Currently, the game's themesong is started by

		global theme
		
		theme = vlc.MediaPlayer("sfx/theme.mp3")
		theme.play()

but when the song finishes, it doesn't loop.

Feel free to push a fix to the beta branch.

When running Tankist in a true client/server configuration, the app becomes stuck infinitely loading.

Two issues must be rectified:

1. The server configuration must be edited to make use of address '0.0.0.0' rather than '127.0.0.1', owing to the fact that 127 is the loopback address.

2. The client listener must be able to find the server at this network address. No fix has been identified thus far.

This issue is for the coordination of efforts, as well as the discussion related to contributing to TankistOnline. Please discuss changes and their implementation here.

We are currently inviting everyone to feel free to contribute.