servergrove / translationeditorbundle Goto Github PK

It is common practice to include the vendor name in the name of a git repository. Doing this allows for multiple vendors to have a TranslationEditorBundle, while a user can still fork all of them. :)

I see you're other bundles already follow a naming scheme like that?

Other than that, interesting bundle!

Right now all my translations are in files called "messages.locale.yml". The bundle will then only import one file since the indexes are created based only on the filename. It should be feasible to add the bundle name in there as well to ensure that there is no name crash.

I've found today that any existing translations located inside the vendors are not included at the interface.

I believe it would be a common request that the validator messages be translated over.

Is there a specific reason for that?

I trie importing from the FOSUserBundle which has 2 files in multiple locales: i.e FOSUserBundle.en.yml, FOSUserBundle.nl.yml.. and validators.en.yml, validators.nl.yml

When i do the import it finds all these files, but when i access the editor it only shows the last file contents, all languages, but only for this filename.

Is this an issue or am i using it wrong?

I keep running into:

Notice: Undefined offset: 2 in /Users/rdohms/dev/webclusive/caas/vendor/servergrove/translation-editor-bundle/ServerGrove/Bundle/TranslationEditorBundle/Command/ImportCommand.php line 88  

This is because this part of the code runs into files that are not translations, so they do not have 2 dots in them. My solution wa to add this before the list command.

if(substr_count($fname, '.') < 2) return;

If my files are formatted like this:

homepage:
    title: Welcome
    sidebar:
        title: Menu
        subtitle: Chose something to do

aboutpage:
    title: About us
    contact: Contact us

Then the bundle will import only 2 keys: homepage and aboutpage with values: Array. Either the import should flatten the file while importing them or it should recursively look for the values.