Formatter is not always called, by Log method about serilog-extensions-logging

[nblumhardt]

Hi John, thanks for the note. Can you please post a snippet of the logging method call, and a sketch of the output you'd expect? Thanks!

[JohnRusk]

I made a wrapper around the Microsoft ILogger, which I'm calling PrefixedLogger. See code below.

So if I do this:
var p = new PrefixedLogger(existingILogger, "foo "); p.LogInformation("bar");

I would expect the output, to the LiterateConsole, to look like:

[13:41:00 INF] foo bar

Effectively I'm trying to simulate a poor-man's version of Serilog's ".ForContext", while keeping my application code dependent only on the Microsoft.Extensions.Logging.ILogger interface. (That means I can't call ForContext directly.)

Breakpoints on the following confirm that augmentedFormatter is never called:

`
public class PrefixedLogger: Microsoft.Extensions.Logging.ILogger
{
private readonly ILogger _innerLogger;
private readonly string _prefix;

public PrefixedLogger(ILogger innerLogger, string prefix)
{
    _innerLogger = innerLogger;
    _prefix = prefix;
}

public IDisposable BeginScope<TState>(TState state)
{
    return _innerLogger.BeginScope(state);
}

public bool IsEnabled(LogLevel logLevel)
{
    return _innerLogger.IsEnabled(logLevel);
}

public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception,Func<TState, Exception, string> formatter)
{
    // construct a formatter that adds our desired prefix to everything 
    Func<TState, Exception, string> augmentedFormatter = (s,e) => _prefix + formatter(s, e);

     _innerLogger.Log(logLevel, eventId, state, exception, augmentedFormatter);
}

}

`

[nblumhardt]

Hi @JohnRusk - sorry about the quiet on this one, with custom wrapper code it's hard to tell what's going on at a glance, and thus a bit tricky to make any useful suggestions.

If you still need a hand with this, or think there's a bug in the provider, please do let us know and we'll reopen. Thanks!

[rf0ster]

Hello @JohnRusk , I am currently having the same issue. Was there ever a resolution to your problem?

[JohnRusk]

I just stopped relying on the formatter object, and did my own string concatenation. Fortunately my case was simple enough for that to be practical. John

…

On 30/12/2017 8:40 AM, "rileyFoster1989" ***@***.***> wrote: Hello @JohnRusk <https://github.com/johnrusk> , I am currently having the same issue. Was there ever a resolution to your problem? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYsDvkVRNXjEzgDQ-_2V24TMRoc-C5DRks5tFUAagaJpZM4NzV_v> .

[rf0ster]

thank you for the response

…

On Fri, Dec 29, 2017 at 2:28 PM, JohnRusk ***@***.***> wrote: I just stopped relying on the formatter object, and did my own string concatenation. Fortunately my case was simple enough for that to be practical. John On 30/12/2017 8:40 AM, "rileyFoster1989" ***@***.***> wrote: > Hello @JohnRusk <https://github.com/johnrusk> , I am currently having the > same issue. Was there ever a resolution to your problem? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/serilog/serilog-extensions-logging/ issues/77#issuecomment-354491422>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AYsDvkVRNXjEzgDQ-_ 2V24TMRoc-C5DRks5tFUAagaJpZM4NzV_v> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFGgBmy1YuPwKhcEiyW3FJYv_xIYh9WEks5tFUtggaJpZM4NzV_v> .