Comments (6)
Nothing is ever trivial 🤣
Turns out StartsWith(char)
was not part of .net fx of good ole time, so I reverted.
Could have gone creative with str is ['@', ..]
, turns out that as optimal as it gets. Felt excessive, though 😏
from serilog-extensions-logging.
Another cheap win in .net < 9.0: StartsWith(char)
is quite faster than StartsWith(string)
on these two lines:
https://github.com/serilog/serilog-extensions-logging/blob/dev/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs#L106-L111
In .net 9+ there's a fast path in StartsWith(string)
that checks if (prefix.Length == 1) return str.StartsWith(prefix[0])
.
from serilog-extensions-logging.
BTW: it would be nice to have similar fast logging when using Serilog natively!
-
MS code generator only targets
M.E.L.ILogger
, we'd need a generator whose template targetsSerilog.ILogger
.
Source code is here: https://github.com/tkrafael/dotnet-runtime/tree/693620ed1425182d1f388f51f06fa18fb6b7e142/src/libraries/Microsoft.Extensions.Logging.Abstractions/gen
It would also be nice to fallback to global staticLog
on static methods if there's no staticILogger
in class. -
Code that writes a
struct
+formatter
efficiently would need to be moved fromSerilog.Extensions.Logging
intoSerilog
core.
from serilog-extensions-logging.
Thanks for all the thoughts and suggestions @jods4!
Anyone keen to investigate/PR any of these? 😎
from serilog-extensions-logging.
@nblumhardt The first changes are so trivial... here you go: #242
I should have opened a different issue for having performant code generator that works with Serilog.Log
.
That's a whole lot more complicated, cannot be closed as quickly 😆
from serilog-extensions-logging.
Thanks again, keen to keep chipping away at these kinds of things, nice to see small gains add up over time :-)
from serilog-extensions-logging.
Related Issues (20)
- AWSSeriLog not working with Maui Blazor App HOT 1
- No exceptions emitted when generated by faulty audit log configuration HOT 4
- Upgrade codebase HOT 2
- Serilog keeps throwing ArgumentNullException HOT 10
- Add API approval test
- Could not load file or assembly 'Microsoft.Extensions.Logging, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' HOT 2
- Serilog.Extensions.Logging 7.0.0 has a .NET 6.0 TFM with dependencies on 7.0 HOT 3
- Serilog.Extensions.Logging v7 .net6 requires v7 Microsoft.Extensions.Logging pkg
- Unit tests fail when run for .Net Framework HOT 2
- SerilogLogger.cs - Always calls formatter with the Exception parameter as null HOT 1
- SerilogLogger.cs: PrepareWrite Method not found Serilog.Events.LogEvent..ctor HOT 3
- Serilog .NET 8 Windows Service (worker) using BackgroundService Log file not found HOT 2
- Pass-through of `M.E.L.ILogger.BeginScope()` when using custom MEL `ILoggingProvider` as Serilog sink? HOT 5
- M.E.L. Log category support exists but is non-obvious on how to include it in text sinks
- Support ActivityTrackingOptions to enrich logs with Activity tags and baggage HOT 5
- Collision with Microsoft.Extensions.Telemetry HOT 1
- `ISupportExternalScope` enrichment HOT 4
- String Quoting - global disable switch HOT 8
- Serilog ignores dotnet logging configuration HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serilog-extensions-logging.