serilog-archive / serilog-sinks-amazonkinesis Goto Github PK

At the moment my Serilog config sits in the JSON files customised for different environments.
Can you give an example of how it is possible to add Kinesis to it?
Thank you!

Hi @serilog/reviewers-amazon-kinesis 👋

Via serilog/serilog#1627 - we're unbundling the serilog organization to help distribute the effort involved in managing the various Serilog sub-projects. The serilog organization will now only manage the fundamental sinks and other packages that the rest of the ecosystem builds upon.

If this package is actively maintained, it can be moved to a new organization managed by the maintainers. Otherwise, it can move to the serilog-archive parking lot, from where we hope a new community-run fork might spring from in the future 🌷 .

Let me know if you're a maintainer and keen to continue this project under a new org; otherwise, I'll shuffle things around and move this one to the archive.

Thanks!

KinesisLoggerConfigurationExtensions.AmazonKinesis always creates DurableKinesisSink instance, regardless if bufferBaseFilename is null or not.
This is because BufferBaseFilename getter adds BufferBaseFilenameAppend to returned value.

Is there any plan to make this compatible with .net core 1.0.0?

My project creates a signed assembly, so I can only reference signed assemblies. Core Serilog is signed, so we've had no trouble using it, but we can't pull in this sink without signing it ourselves. Why is that? Isn't this an official Serilog project?

When I issue the .WriteTo.AmazonKinesis, I am getting a System.IO.FileNotFoundException: Could not load file or assembly 'Serilog.FullNetFx, Version=1.5.0.0.

I'm using .NET 4.5.2 and Serilog.Sinks.AmazonKinesis v2.1.97 which I installed via nuget into my Visual Studio solution.

Both the Kinesis stream and the Kinesis client to talk to it are created successfully. Here is the code snippet which is essentially taken from github sample app:

            const string streamName = "my-splunk-kinesis";
            const int shardCount = 1;

            var client = new AmazonKinesisClient(RegionEndpoint.USEast1);
            var streamOk = KinesisApi.CreateAndWaitForStreamToBecomeAvailable(
                kinesisClient: client,
                streamName: streamName,
                shardCount: shardCount
            );

            return new LoggerConfiguration()
                .WriteTo.AmazonKinesis(
                    kinesisClient: client,
                    streamName: streamName,
                    period: TimeSpan.FromSeconds(2),
                    bufferBaseFilename: "./logs/kinesis-buffer"
                )
                .CreateLogger();

The RollingFile sink creates a SharedFileSink when you pass the shared flag (serilog/serilog#1005).

Is it possible to add a setting to the KinesisFirehoseSinkOptions to pass a shared setting to the underlying RollingFileSink?

It looks like it could be set here:
https://github.com/serilog/serilog-sinks-amazonkinesis/blob/master/src/Serilog.Sinks.Amazon.Kinesis/Firehose/Sinks/DurableKinesisFirehoseSink.cs#L39

I would be happy to create a PR for this change.

If there is any error in the KinesisFirehose Sink while putting records to Kinesis Fire hose , the sink does not invoke the onLogSendError even though it is part of the options .Works fine with DurableKinesisFireSink.

The AmazonKinesis project references version 3.3 of the RollingFileSink. The AmazonKinesisis nuget package references 2.2. There was a parameter added to the constructor of the RollingFileSink called Shared which is being used that is not available in 2.2, so you get a missing method exception. There is a work around. You just need to also include the 3.3 version of the RollingFileSink nuget package in the project that uses AmazonKinesis.

Looks like the AWSSDK dependencies do not support .Net standard based on the version in nuget. Any estimate on when a latest nuget package will be released with the latest updated .Net Standard support?

Readme file mentions the use of SelfLog.Out = Console.Out; but the SelfLog.Out method is deprecated. The right command is SelfLog.Enable(Console.Error);

Proposed PR #43