sergioluis / dotboy Goto Github PK

IntegrityCheckPasssed is calculated wrong.

In dotBoy.Core/Rom.cs

Posted via CodeStream

RomLoader implementation uses System.IO.FileStream, with its FileStream(String, FileMode) constructor. Below, the description says:

You cannot use this constructor to open read-only files; instead, you must use a constructor that accepts a FileAccess parameter with the value set to FileAccess.Read.

Should RomLoader have write permission? I suggest using read permission only, like this:

FileStream fs = new FileStream(path, FileMode.Open, FileAccess.Read

Note how all this has a side effect. RomLoader requires write permision, and any attempt of reading a file without it will end with a SecurityException thrown (well, experimentally, its subclass UnauthorizedAccessException).