Coder Social home page Coder Social logo

How to display failure about remix-auth HOT 5 CLOSED

JSLNO avatar JSLNO commented on May 18, 2024 2
How to display failure

from remix-auth.

Comments (5)

sergiodxa avatar sergiodxa commented on May 18, 2024 1

All the strategies catch the errors your throw and wrap it in a Response.

If you defined a failureRedirect, the response would be a redirect and the error will be in the session.

If you didn't defined a failureRedirect, the response will be a 401 with the error as part of the body. This one could be accessed in a CatchBoundary component.

And you can wrap the authenticator.authenticate call in a try/catch and manually check the response and handle the error.

from remix-auth.

JSLNO avatar JSLNO commented on May 18, 2024

All the strategies catch the errors your throw and wrap it in a Response.

If you defined a failureRedirect, the response would be a redirect and the error will be in the session.

If you didn't defined a failureRedirect, the response will be a 401 with the error as part of the body. This one could be accessed in a CatchBoundary component.

And you can wrap the authenticator.authenticate call in a try/catch and manually check the response and handle the error.

I don't get why but when I try using a try/catch block theres always an error thrown even when the credentials are correct. But when I remove the block it works how it is supposed to. Here's the action function I currently have:

export const action: ActionFunction = async ({ request }) => {
    try {
        await authenticator.authenticate('local', request, {
            successRedirect: '/'
        })
    } catch (e) {
        if (e instanceof Response) {
            const data = await e.json()
            return { error: data.message }
        }
        throw e
    }

    return {}
}

This works when the credentials are incorrect, but when they are correct, it throws:
FetchError: invalid json response body at reason: Unexpected end of JSON input

from remix-auth.

sergiodxa avatar sergiodxa commented on May 18, 2024

That’s because the library made use of Remix ability to throw responses including redirects

from remix-auth.

JSLNO avatar JSLNO commented on May 18, 2024

Sound's interesting, do you have any suggestion on how I could fix it?
Thanks

from remix-auth.

JSLNO avatar JSLNO commented on May 18, 2024

Sound's interesting, do you have any suggestion on how I could fix it? Thanks

Okay, I got it working like this:

export const action: ActionFunction = async ({ request }) => {
	try {
		await authenticator.authenticate('local', request, {
			successRedirect: '/'
		})
	} catch (e) {
		console.log(e)
		if (e instanceof Response && e.status === 401) {
			const data = await e.json()

			return {
				error: data.message || 'Unauthorized'
			}
		}
		throw e
	}

	return {}
}

from remix-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.