seomoz / roger-mesos-tools

Tools to interact with RogerOS (roger-mesos)

roger-mesos-tools

Tools to connect to and work with RogerOS, Moz's cluster OS based on mesos.

Build

$ python setup.py build

Run tests

$ python setup.py test

Generate source distribution

$ python setup.py sdist

Install

$ python setup.py install OR pip install -e .

Use

• roger -h
• roger <command> -h

Uninstall

pip uninstall roger_mesos_tools

With virtualenv

virtualenv venv
source venv/bin/activate
pip install -e .
# run roger commands
deactivate

roger-mesos-tools's Issues

Fix issue with get_app_id

It looks like the method is defined in the ABS, then also implemented in the framework classes, but with a different signature that is incompatible with who it is called from roger_promote. Resolve in a branch and try from the roger-cli vagrant box by running /vagrant/scripts/get-roger-tools install BRANCH_NAME in the roger-cli VM. When it's working, make sure the unit tests pass and submit a PR for review.

Only do image splitting if a / is present

RE: roger_promote

If the image is going to a private repo, a slash will be present in the image name. In this case, we must split. Otherwise, don't split.

Doc needs update

https://github.com/seomoz/roger-mesos-tools/blob/master/cli/marathon.py#L283

Should be dict

roger_promote needs shebang line

Add #!/usr/bin/env python to roger_promote.py

roger gitpull errors with "environment" arg not defined

I'm admittedly working with a Roger VM I haven't touched in a while. I rebuilt my local VM and tried getting the code for an existing Roger project into the VM, and I ran into some troubles with the gitpull tool.

Granted, I am very unfamiliar Roger CLI internals and with Python in general, so this is a shot in the dark. I believe the code that parses the arguments fails to pull in an environment property on my build. Moreover, looking at the code, it appears to set up a default environment local variable that is overridden by the args and then runs the procedure without actually using it.

Roger version:

vagrant@roger-cli:~$ roger -v
0.4.24

Command output

vagrant@roger-cli:~$ roger gitpull sodo local_deploys local.json
root: /usr/local/lib/python2.7/dist-packages command: gitpull args: ['sodo', 'local_deploys', 'local.json']
Args parsed:
Namespace(app_name='sodo', branch=None, config_file='local.json', directory='local_deploys', verbose=False)
******Executing GIT PULL of application repo******
ERROR:root:'Namespace' object has no attribute 'environment'
Traceback (most recent call last):
  File "/usr/local/bin/roger_gitpull.py", line 97, in main
    exit_code = hooksObj.run_hook(hookname, data, args.directory, args.environment, settingObj.getUser())
AttributeError: 'Namespace' object has no attribute 'environment'
/usr/local/bin/roger_gitpull.py:119 fn:main - AttributeError("'Namespace' object has no attribute 'environment'",)
ERROR:root:'Namespace' object has no attribute 'environment'
Traceback (most recent call last):
  File "/usr/local/bin/roger_gitpull.py", line 138, in <module>
    roger_gitpull.main(settingObj, appObj, gitObj, hooksObj, args)
  File "/usr/local/bin/roger_gitpull.py", line 97, in main
    exit_code = hooksObj.run_hook(hookname, data, args.directory, args.environment, settingObj.getUser())
AttributeError: 'Namespace' object has no attribute 'environment'
/usr/local/bin/roger_gitpull.py:140 fn:<module> - AttributeError("'Namespace' object has no attribute 'environment'",)

Some tests aren't properly mocked

https://travis-ci.org/seomoz/roger-mesos-tools/builds/184310702

I fixed the travis by installing the tool and the test dependencies and removing pep8 checks since there are violations everywhere. Some calls still don't mock properly, causing it to fail. See the link above for more details of the failing tests.

Python 3 support

Hello,
I'm just starting to test project, but seems it only supports python 2.x.
Is there a plan for supporting py3?

Perform JSON validation on the template file

Helpful for the user.