sendouc / sendou.ink Goto Github PK
View Code? Open in Web Editor NEWCompetitive Splatoon Hub
Home Page: https://sendou.ink
License: GNU General Public License v3.0
Competitive Splatoon Hub
Home Page: https://sendou.ink
License: GNU General Public License v3.0
On the FA page, notice how the phrase Filter by ...
is used three times. The first two filters show FA's who fit that criteria, implying Filter by
includes the criteria and excludes those not matching criteria. Conversely, the Filter by weapon
dropdown (which is beautiful btw) works the opposite.
Intuitively, one would suspect that this filter would work in the same way as the first two - I did as I was searching for a Bamboo main and thought it was odd that they all disappeared. I'd argue this type of behaviour is more intuitive and useful, since inclusivity is more important when looking for a teammate - you'd need to really hate a weapon to purposefully exclude it.
I'd also argue that the matching feature should be more obvious - if I get a like I should be able to see who it is. Paginating through ~296 FA's can be such a teasing guessing game. The reason it works with dating apps is because you're presented the matches in a gamified format.
And finally, your code quality is very good! I wish my coworkers kept their code this clean.
From a fellow software engineer who focuses on UX :) if you'd like to dm to discuss, you can find me at drew#6949.
Implement the new calendar page look (this already exists somewhere)
I should be able to reset build to default question marks state with a button. Currently to reset you have to click each ability separately which is tedious. Check for example how https://loadout.ink/en-us/#0000000000000000000000000 does it
As of right now, the maplist queries send more data than nessecary.
Change the maplist query to take an optional name:
argument to return the specific maplist.
Additionally, add an optional index:
argument to return a maplist at a specific index.
For backwards compatibility, you can also just add a new query called maplist
(vs maplists
) to return a specific maplist.
Mostly done on https://github.com/Sendouc/sendou-ink-mono. Waiting on Chakra UI 1.0
FAQ for people to explain the whole thing. Needed when it goes public.
Plus page should be visible for everyone to take a look
like how much damage does a weapon do, how much endlag does it have or similar, as example if I'd like to know how much damage the Tenta Brella shield does upon collision, or what the base HP for the regular brella is, the endlag on blasters or sloshers and stuff like that, maybe not even the endlag things but I was mainly concerned about weapontraits like brella HP or brella damage right now
it's mainly invariable constants, but I think it'd be a good addition if you don't want to rely on wikis so much
https://twitter.com/TobyBaratta/status/1278954990317367297
Mainly referring to this, since it's uneditable after you posted it you can't include a registration link before opening registration
My idea is to give post rights to a permitted group (people who ask for it) so you can monitor it easily while still leaving the original posters freedom to edit the messages
Not sure how feasible it is to implement this (especially with the discord-posts), but the Calendar is the imo most underappreciated feature of sendou.ink
Bot should update avatars of users so that they don't 404 on sendou.ink
When it releases for real or at least wait till rc4 since rc3 seems broken for color mode.
Was this build helpful? (QoL improvement)
Something to make builds have a bit of a feedback would be to add counter of how many players that build helped them. (Like in articles or answers for technical support that ask in the end if the answer was helpful or not. could be anonymus, could be yes or no question, could be just counter or could be just how many people saw your build. Not something crucial but suggestion nonetheless.
Hebrew translation
I can help with trasnlating sendou.ink to Hebrew. I see the site has been translated to languages that Splatoon 2 does not support in translations to them so I'm offering my help with translating to another language. Just let me know what I need to do and I'll gladly help with the translations.
Clash Blaster
Something really minor. The clash blaster in the search bar and in map planner appears after Rapid pro deco. I assume you took it from Inkipedia which I put it there by accident. The order that appears in the game that is sorted by main is an order that usually shows from short to long range and then unique mechanic (like the blasters, burst fire, sloshers for example). The correct order of clash is actually after the Grim Blaster.
https://splatoon2.ink/data/locale/en.json
Kind regards,
Shahar
e.g. hide tournaments happening at certains times
top 500 for june2020 doesnt seem correct
Should be able to add "ad" banners after nav rework on the admin panel.
Take the wrapping feature from https://github.com/Sendouc/sendou-ink-mono after updating Chakra UI to 1.0
Take the updates from https://github.com/Sendouc/sendou-ink-mono
28.7.2019 klo ~15:05
Käytin sovellusta kirjautumatta
Kirjauduin
README voisi sisältää enemmän kuvausta mikä palvelu on.
Planin teko hajoaa jos piirrät kuvaa jonka jälkeen menet muulle sivulle ja palaat plans sivulle.
Esimerkillinen palvelu. Löysin koko läpikäynnillä vain yhden ongelman.
Tiedostot hyvin nimettyjä.
Frontin komponentit ehkä hieman kummallisesti kansioitu. Esimerkiksi components kansion alikansiot voisi nimetä paremmin.
Kaikki kolme tiedostoa BuildCollection.js, Build.js ja AbilityButtons.js alkavat samalla import matolla. Kaikki ikonit / nimet / etc voinee yhdistää toisessa tiedostossa ja hakea sen yhden tiedoston komponentteja varten.
Tiedoston AbilityButtons.js return näyttää myös siltä että voisit säästää rivejä käymällä listaa läpi.
Paikoitellen returniin on laitettu paljon logiikkaa. Esimerkiksi https://github.com/Sendouc/sendou-ink/blob/b2070fce5ccbf8df2169443ae7420a0246eaf76e/react-ui/src/components/SoloLadder/BuildTab.js on hieman ensisilmäyksellä monimutkainen loitsu "!user || user.discord_id !== userViewed.discord_id || data.searchForBuilds.length >= 100" jonka kaverina on "data.searchForBuilds.length >= 100 && user && user.discord_id === userViewed.discord_id".
Toisaalta taas samassa tiedostossa seuraavalla rivillä showForm on selkeä.
https://github.com/Sendouc/sendou-ink/blob/b2070fce5ccbf8df2169443ae7420a0246eaf76e/index.js#L17 portti kannattaa laittaa riippumaan samassa tiedostossa sijaitsevasta PORTista.
Ongelmia piti hakemalla hakea, jatka samaan malliin!
Työstä huomaa aiheen olevan lähellä tekijää ja laatu on myös sen mukaista.
🦑 / 🚸
Just a quality-of-life thing that would be nice to have. LUTI divs, timezones, XP, etc. are all hard to filter by, and it’s hard to search up someone’s username if you want to see their FA post.
Social media preview images + texts (not even showing a picture when linked on Discord/Twitter rn)
https://carbon.now.sh/ something like this for builds/fa's/more?
One page for tournaments by ganba + +1/+2 draft cups + more in the future
Not sure if anything is going to change in the page or if you have other plans for this feature
Take new system (don't show old FA's and ask people to refresh their FA'ness) and some UI changes from the UI rework branch
Some ideas:
- [ ] Allow adding endorsements and deleted by the endorser or FA
Direct link FA post - via query string allow focusing on one fa post -> if found show on the top highlighted. Also could be useful when clicking matched FA
FA card redesign (table?)
- [ ] More visual filter options (pie charts for roles e.g.)
Take new UI from UI rework branch
Could consider moving to Next.js when the localization update comes. In the meanwhile doing some things that would make it easier.
Currently can only click. Would be intuitive to also drag abilities to slots. Check how it works on https://loadout.ink/en-us/
Builds can be made on user page and build analyzer so this should work on both.
Bonus: Maybe hold Shift to duplicate? So while hold switch and drag from ability already selected it stays in that slot but multiplies and you can drag it to another slot.
Should make it as easy as possible for new contributors to get the project up and running. Docker?
Npm 7? Yarn Workspaces? Lerna?
Goal is to have one common code base for the Discord bot (Lohi), Next.JS and upcoming React Native app.
Code sharing should be effortless. E.g. with hooks I should just be able to change the UI between web and native and still be using the same data fetching and other logic.
Is Ancho-V Games missing from the map pool in the planner?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.