senderle / c18topics Goto Github PK

On resize now, a JS error reports:

Uncaught TypeError: svg.attr is not a function
    at resize (plot.js:36)
    at d3.v3.min.js:1

Seems to have something to do with the way the callback is receiving the svg object. It might be necessary to get the svg object into the resize function's closure.

Not sure why, but it looks like the recent refactoring is causing a problem when you click on a node to hide the label and then restore it. The label comes back twice as large, and an error appears in the console.

Right now, we just pull a static graph.json file. But it would be cool if instead, we could specify a data file dynamically, say, using an html fragment? That way, instead of having to create five folders to create five graphs, we could have just one folder with five different graphs.

Since different graphs might have subtly different settings, we might also want to pull out a settings json file? We could also have the settings stored inside the graph json file, but that seems too tightly coupled to me.