sencha / ext-web-components Goto Github PK

i found this bug, fix need change "isClassicDock(childxtype)" to "isClassicDock(childCmp)"

Hi folks,

I hadn't looked at Sencha for a long time, but when hunting for a new JS UI lib I thought I'd give it another look. The first thing I randomly chose was the ResizableLayout demo, but it seems kinda broken.

Environment
Windows 10
Google Chrome 85.0.4183.121 (Official Build) (64-bit)

Observed Behavior
If you drag the bottom section entitled Dock Bottom downwards a little and let go, it disappears completely. Also if you drag it up it seems to land in unexpected places

Expected Behavior
Not really sure. I guess I expected it to smoothly resize? It seems generally jank to me

for example:
<ExtGrid> <ExtRownumberer/> </ExtGrid>

file common\util.js
function isParentGridAndChildColumn
change
if (parentxtype === 'grid' && childxtype.includes("column")) {
to
if (parentxtype === 'grid' && (childxtype.includes("column") || childxtype === 'rownumberer')) {

for example
<ExtGrid> <ExtGridcolumn text="name" dataIndex="name" /> </ExtGrid>

the ExtGridcolumn is put in items of ExtGrid, and put in items of getHeaderContainer of ExtGrid is right

i changed “parentCmp.add(childCmp)” to "parentCmp.getHeaderContainer().add(childCmp)" below case isParentGridAndChildColumn , and fix this problem

maybe with location has same problem