wfMsg, wfMsgExt and wfMsgHtml are deprecated about semanticwatchlist

[kghbln]

Pull request #25 addresses wfMsg

[kghbln]

Pull request #26 addresses wfMsgExt

[kghbln]

The last transgressor:

Will this be the correct change?

wfMsgHtml( 'swl-watchlist-pagincontrol', $wgLang->pipeList( array( $firstLink, $nextLink ) ), $wgLang->pipeList( $limitLinks ) )

to

wfMessage( 'swl-watchlist-pagincontrol' )->rawParams( $wgLang->pipeList( array( $firstLink, $nextLink ) ), $wgLang->pipeList( $limitLinks ) )->escaped()

@JeroenDeDauw

[kghbln]

@JeroenDeDauw It will be cool if we get this (#10 (comment)) into 1.0 Just advise if this change is cool and I will do a pull request for it.

[JeroenDeDauw]

I've not used the MW i18n system for two years or so, hence I cannot tell if that is correct or not. Ping @Nikerabbit @siebrand

[kghbln]

@siebrand This is the resistor: #10 (comment)

[siebrand]

This:

wfMsgHtml( 'swl-watchlist-pagincontrol', $wgLang->pipeList( array( $firstLink, $nextLink ) ), $wgLang->pipeList( $limitLinks ) )

Should be converted to wfMessage as:

wfMessage( 'swl-watchlist-pagincontrol' )
->rawParams(
$wgLang->pipeList( array( $firstLink, $nextLink ) )
$wgLang->pipeList( $limitLinks )
)->escaped()

This results in 'swl-watchlist-pagincontrol' being escaped, and the parameters being used as raw parameters. The solution suggested in the earlier comment, would have resulted in escaped links.

[kghbln]

Thank you very much! Well this is just a single comma difference in text but a big difference in result. Will revisit this to understand it better! Will do the change now. Great!

[siebrand]

Oh, wait. You did use rawParams. In that case, please ignore my semantically incorrect suggestion. You did do it correctly.

[kghbln]

Fast enough :)

[kghbln]

Thanks again @siebrand It took me a long time but with this pull request #37 the migration is finally done for this extension.

[kghbln]

This was the last hold-up for #36