Got explicit BEGIN from DatabaseBase::begin while atomic section(s) RenameuserSQL::rename are open. about semanticwatchlist

[mwjames]

Got explicit BEGIN from DatabaseBase::begin while atomic section(s) RenameuserSQL::rename are open.

Doing a begin/commit [0] will most certainly break transactions in MW 1.27+ hence why SMW is doing [1].

Try to replace ->begin with ->startAtomic( __METHOD__ ) and ->commit with ->endAtomic( __METHOD__ )

[0] https://github.com/SemanticMediaWiki/SemanticWatchlist/blob/master/src/TableUpdater.php#L40-L53

[1] https://www.semantic-mediawiki.org/wiki/Deferred_updates

[kghbln]

Try to replace

Great, this was it! After getting atomic is was able to successfully rename a user. I will create a pull.