segment-integrations / analytics-ios-integration-facebook-app-events Goto Github PK

Please update Facebook SDK to the 5.x version as it is the latest version of SDK. This library is using an older version of the SDK. I have tried to create a pull request after updating it to the latest version, but I don't have the right to push the changes.

There is a new version of Facebook SDK 14.x and it shows a warning in the FB dashboard

Our events contain properties that are dictionary objects themselves. As a result, seeing this warning in the console FBSDKLog: The values in the parameters dictionary must be NSStrings or NSNumbers It would be great for this library to automatically filter out those properties so I don't get those pesky warnings when running the app. I tried to use the event parameter whitelist feature in the segment dashboard but it doesn't seem to change anything.

Advanced Matching Doesn't Work With iOS 14 in Older Versions of the Facebook SDK

Facebook can't use the Advanced Matching feature to match your app events to Facebook account IDs for iOS 14 customers. Update to Facebook SDK version 8.0 or higher to fix this issue.

Screen names are optional as per our spec - so we should fallback to category if one is not defined.
https://github.com/segment-integrations/analytics-ios-integration-facebook/blob/master/Pod/Classes/SEGFacebookIntegration.m#L74

I have been using Segment and other destination frameworks to manage event tracking. My latest build on Appstore has following Segment SDKs.

POD LOCK File

PODS:
  - Analytics (4.1.1)
  - AppsFlyerFramework (6.0.8)
  - Intercom (8.0.0)
  - FBSDKCoreKit (7.1.1):
    - FBSDKCoreKit/Basics (= 7.1.1)
    - FBSDKCoreKit/Core (= 7.1.1)
  - FBSDKCoreKit/Basics (7.1.1)
  - FBSDKCoreKit/Core (7.1.1):
    - FBSDKCoreKit/Basics
  - segment-appsflyer-ios (6.0.3):
    - Analytics
    - AppsFlyerFramework (~> 6.0.3)
  - Segment-Facebook-App-Events (2.0.1):
    - Analytics
    - FBSDKCoreKit (~> 7.1.1)
  - Segment-Intercom (1.0.1):
    - Analytics
    - Intercom

DEPENDENCIES:
  - segment-appsflyer-ios
  - Segment-Facebook-App-Events
  - Segment-Intercom

COCOAPODS: 1.10.1

It seems FBSDK is dependency from Segment Facebook App Events library and it is obvious that FBSDK pod added here is version 7.1.1 which I believe is compatible with Segment Framework.

The issue here is, I keep getting "Update FB SDK" message in my FB Ad Console which indicated the FB SDK is outdated and I must update FB SDK to run our app on iOS 14. Though, my app is already working fine on iOS 14.

Would you suggest me is this change required and how would I be able to do the change?
What kind of changes are visible post the upgrade?

When using the FB App Events integration and attempting to track events, the following error is thrown for long event names or those with characters that FB SDK doesn't approve:

Must be between 1 and 40 characters, and must be contain only alphanumerics, _, - or spaces, starting with alphanumeric or _.

In our case, the event names have periods. e.g. app.search.successful. Therefore they do not work.
Not sure what ideal solution is, but would be worthwhile adding this info the docs as otherwise events wont' appear in the FB Analytics panel.