seeksaveserve / pe Goto Github PK

Given that a markroomsunclean command exists, it is strange that the reverse command (marksroomsclean) does not exist.

It is clear that keywords for names are searched by words.

However, the definition and constraints of keywords are not clearly explained for room. And it is unclear that find 05 is invalid since it is not specified that room must be specified in full

The Guest box has many children connected to it, and it is quite crammed. One remedy for this is to make the Guest box larger

Changing the json data to invalid ranges will disable the app and prevent it from reading all data correctly.

In the event of a data corruption (that is not triggered by the user), it will be difficult to figure out what has went wrong with the app.

An error message should be thrown out when loading the data.

In the user guide, it is specified that

However, when the following command is entered, no results are displayed despite there being residents residing in rooms starting with 05.

As a CLI user, i expect to take me back to the command window with 1 .

However, the current app takes more than 1 to return to the command window again.

This is likely due to the traversal policy of the app.

This behaviour differs from the user guide which specifies that the

However, when the command is copy pasted over, this does not work.

It is not clear from the documentation alone that there is a formatting issue with the command. And the user has to do his own testing to figure out what is the proper way to type an add command.

As a hotel manager, I expect to be able to search residents by their floor.

However, the find function currently does not permit this.

As such, it is difficult for a manager to know everyone who stays on a given floor with the app.

This command is missing a space after the '-' in the date segment of the command when copy pasted directly into the app.

The parser is very strict, and any additional white space in the command will not work.

This is frustrating when the command is long.

E.g. the sample command given in the UG

will fail because of the additional white space pasted over.

This is potentially bad for fast typers because a benign mistake will cost him/her to spend additional time checking the command for extra white spaces. This is arguably a penalty for speed typers since they have no room for error. And the speed gain from having CLI commands is nullified due to the time spent on correcting commands.

Transition should be used here instead

The edit 2 rm/lolFakeRoom command is permitted. Which is strange since this is clearly a garbage value and a room number that does not exist is added.

A stricter parser should be implemented given that room numbers are quite important for a hotel. And inaccuracies in such information can cause major mishaps.
Further, being able to input whatever I want does open the app for potential injection attacks.