pe's People
pe's Issues
No command to mark all rooms as clean
Given that a markroomsunclean
command exists, it is strange that the reverse command (marksroomsclean
) does not exist.
Find keywords for room number is not clearly explained
Messy diagram
No error message for corrupted save file
Changing the json data to invalid ranges will disable the app and prevent it from reading all data correctly.
In the event of a data corruption (that is not triggered by the user), it will be difficult to figure out what has went wrong with the app.
An error message should be thrown out when loading the data.
Find command does not match keywords for rooms
<Tab> does not immediately toggle the command window
As a CLI user, i expect to take me back to the command window with 1 .
However, the current app takes more than 1 to return to the command window again.
This is likely due to the traversal policy of the app.
Add command example given in UG fails parser
This behaviour differs from the user guide which specifies that the
However, when the command is copy pasted over, this does not work.
It is not clear from the documentation alone that there is a formatting issue with the command. And the user has to do his own testing to figure out what is the proper way to type an add command.
Cannot search residents by floor
As a hotel manager, I expect to be able to search residents by their floor.
However, the find function currently does not permit this.
As such, it is difficult for a manager to know everyone who stays on a given floor with the app.
Some commands from the UG are invalid due to formatting
Command parsing is rigid and can be frustrating when used in conjunction with long commands
The parser is very strict, and any additional white space in the command will not work.
This is frustrating when the command is long.
E.g. the sample command given in the UG
will fail because of the additional white space pasted over.
This is potentially bad for fast typers because a benign mistake will cost him/her to spend additional time checking the command for extra white spaces. This is arguably a penalty for speed typers since they have no room for error. And the speed gain from having CLI commands is nullified due to the time spent on correcting commands.
Transit is the wrong verb form, should be transition
Invalid / garbage values can be used for room details
The edit 2 rm/lolFakeRoom
command is permitted. Which is strange since this is clearly a garbage value and a room number that does not exist is added.
A stricter parser should be implemented given that room numbers are quite important for a hotel. And inaccuracies in such information can cause major mishaps.
Further, being able to input whatever I want does open the app for potential injection attacks.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.