seeker / dwarftherapist Goto Github PK

It's should be a short, but tends to read bogus data. Need to find the real 
location

One-time (presumably) bulk-load of current custom professions
Just pick first dwarf as the template as a starting point for users

On the tooptip for the dwarf names, suggest listing labors highest-to-
lowerst rank.
Also suggest rendering inactive labors in an alternate way/colors (gray 
italics?)

Military scope: active/champion tooptip has alternate behavior that 
ignores labors - like a cool champion graphic or 'Active Duty 
serving "squad leader name" ' or something

Allow user to build a custom tab that displays a particular set of skills.
Subfeature: toggle Show/Hide Dorfs with labor active
Subfeature: toggle Show/Hide Dorfs with > 0 skillpoints in labor

Def. need a single R-click 'set/remove' or a preference to turn on single-
click

Personally I don't like single-click on the L-click because I like to poke 
the grid to move my focus around with the guides to analyze stuff, and 
would like a R-click to set/remove a skill.

This combined with removal of the X graphic of the cursor would be ideal 
for me; may want to experiment with how to handle removal of the cursor - 
should it be invisible, or try a bolded square the same color as the 
guides? I think it's the X that's really turning me off - inconsistent 
lines on the screen. Oh hey look at that i mashed two issues in to one. 
HOT!
To be fair it's hard to discuss single-click without discussing the cursor 
scheme. So...I'm leaving this as is. nyah!

With non-default colors selected:
Open color selector
Click Reset to Defaults
Choose Cancel
Colors are reset to defaults

Expected: No color changes on cancel action

My personal feelings on this is the user should be punished for 
drunken/lazy clicking and no change is needed. However, if you are feeling 
benevolent, perhaps pop a confirm message or otherwise discard on cancel.

What steps will reproduce the problem?
1.Opening the program.

What is the expected output? What do you see instead?
"Dwarf Therapist has encounter a problem and needs to close..."

What version of the product are you using? On what operating system?
I've tried 0.1.5 and 0.1.6. Windows XP. Odd thing, 0.1.5 worked fine 
yesterday.

Please provide the "run.log" file in the "log" directory of DwarfTherapist
when this error occurred.

Try to keep it abstract so custom methods can be created in the future. For 
now grouping by profession should be good enough.

Wondering if there is merit to making the custom professions live in their 
own config file and/or add an export-backup professions feature. Look to 
you for guidance per code and visioning.

I can kinda see where folks with many forts may want to import a bunch 
professions and maybe manage them independently. Dunno, i have not really 
thought this through. 
But that won't stop me from hitting submit button. MRAH!

Should be a series of bytes, but I'm not sure whether to interpret them as 
bits or 1byte ints.

Deleted profile .ini file
extracted new 0.1.1
loaded up dwarves & custom professions
professions appear, however editing (double click or r-click) produces a 
blank window.
Same result using Add custom profession function.

provide a link for donating and split some with bay12

Left to Right:
Mining Group : #F8F8FF
 Mining

Carpentry Group : FFFFE0
 Bowyer
 Carpentry
 WoodCutting

Stone Worker Group : #FFFFFF
 Mason
 Stone Detailing
 Architecture

Animal Group : #F0FFF0
 Animal Training
 Animal Care
 Animal Dissection
 Hunting
 Trapping

Metal Worker Group : #F8F8FF
 Armorsmithing
 Furnace Operating
 Metalcrafting
 Blacksmithing
 Weaponsmithing

Gem Group : #F5FFFA
 Gem Cutting
 Gem Setting

Crafting Group : #F0FFFF
 Bonecarving
 Clothesweaving
 Glassworking
 Leatherworking
 Stonecrafting
 Weaving
 Woodcrafting
 Strand Extracting

Workers Group : #FDF5E6
 Brewing
 Butchery
 Cheesemaking
 Cooking
 Dyeing
 Farming
 Plant Gathering
 Lye Making
 Milking
 Milling
 Potash making
 Soapmaking
 Tanning
 Plant Processing
 Wood Burning

Fishmonger Group : #F0F8FF
 Fishing
 Fish Cleaning
 Fish Dissection

Engineering Group : #FFF5EE
 Mechanics
 Pump Operating
 Siege Engineering
 Siege Operating

Hauler Group : #E0FFFF
 Health Care
 Animal Hauling
 Wood Hauling
 Item Hauling
 Food Hauling
 Stone Hauling
 Refuse Hauling
 Furniture Hauling
 CLeaning
 Burial

Alchemy : #FFFFFF

A column listing current job next to the dwarf names column, sortable by
job in order to get those "no job" losers working quickly.

Summary is description.

For those who want a cleaner display. Like me.

I WANT RED waaahhhhhhh

What steps will reproduce the problem?
1.Load a fortress (Mayday, 40d11)
2.Try to import dwarves
3.Nothing happens

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
40d11, Windows Xp MCE

Please provide the "run.log" file in the "log" directory of DwarfTherapist
when this error occurred.

Currently the labor plots rank skill 1-10 in a fixed square inside the 
gird, and change gradient based on the value (1 = lighter, 10=darkest)
From 11-15 ... i forget what you're doing , the large baby blue box thing 
or something?
and anyway 16 is the diamond square. Which rules. 

How about adding the option for going back to the sizing scale but 
slightly different than dwarfmanager:
From 1-10, itty dot that grows larger. Fixed grayscale color.
 1-5 : 4pt gray
 5-10 : 6pt gray
From 11-15, larger dot but blue color
 11-12: 8pt blue
 13: 11pt blue
 14: 13pt blue
I'm just taking a stab at the pt measures based on 16x16

Custom profession tags are truncated in the game at 15 characters but DT 
allows longer.
This disconnects the custom professions from the loaded professions in the 
game.

During use i find myself always sorting by alpha, it's habit now that as 
soon as I open DT i r-click the upper left to get the dwarves in the group-
by 'nothing' list to sort Alpha asc.

Would be a nice UI consistency perk to auto-sort alpha desc by name or 
save sort on exit.

Maybe more will be present in here later, but was thinking it might be 
easy/nice to clean this up a tad
Currently Shows as:
-----
Labor Name

# (skill rank number)

Nickname Lastname
-----

Suggest a quick cleanup to remove the empty lines and show:
-----
(3) Competent Bone Carver
"Onyx" Blackman
-----

Or even something simpler, just tighten up the display a scootch and 
remove the empty lines.

[13:18:38.031] [Info] Dwarf Therapist 0.1.5 starting normally. 
[13:18:38.125] [Debug] .\src\mainwindow.cpp (ln 62 ):  setting up
connections for MainWindow  
[13:18:38.140] [Debug] .\src\mainwindow.cpp (ln 97 ):  begining to read
settings  
[13:18:38.140] [Debug] .\src\models\dwarfmodel.cpp (ln 233 ):  group_by now
set to 0  
[13:18:38.140] [Debug] .\src\mainwindow.cpp (ln 158 ):  finished reading
settings  
[13:18:38.140] [Debug] .\src\mainwindow.cpp (ln 207 ):  attempting
connection to running DF game  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 484 ):  attempting to find
running copy of DF by window handle  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 493 ):  found copy with
HWND:  0x960944  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 497 ):  PID of process is:
 2092  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 56 ):  working set size: 
222.781 MB  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 59 ):  PEB is at:  0x7ffdf000  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 73 ):  read 12 bytes BASE
ADDR is at:  0x400000  
[13:18:38.140] [Debug] .\src\dfinstance.cpp (ln 82 ):  DF's checksum is:
4a3ccb7f  
[13:18:38.140] [Warning] "Couldn't find key
'checksum_to_version/0x4a3ccb7f' in file
'C:/dwarfort/DwarfTherapist_RC2_R71/etc/game_data.ini'"  
[13:18:38.890] [Debug] OUR VERSION: "0.1.5"  
[13:18:38.890] [Debug] LATEST VERSION: "0.1.5"  
[13:18:39.734] [Critical] .\src\dfinstance.cpp (ln 89 ) [
DFInstance::DFInstance ]  unable to identify version from checksum: 4a3ccb7f  
[13:18:39.734] [Debug] .\src\dfinstance.cpp (ln 95 ):  memory correction  0  
[13:18:39.734] [Debug] starting with creature vector -1  

When single L-click on Custom Professions list, move focus in main grid to 
that custom profession (if present) and expand that group

When horizontal r-scrolling the dwarf list leaves focus. Ideally, like the 
column headers, this would be frozen.

For mortals with less than a 27.5" viewable LCD i can see this becoming a 
highly requested feature that is already present in dwarfmanager.

I, however, have no such need. 

Leaving milestone blank for you to decide how important this is for alpha.

What steps will reproduce the problem?
1. Start Dwarf Fortress
2. Load save game
3. Open Dwarf Therapist
4. Click 'Read Dwarves'

What is the expected output? What do you see instead?
Control 1: Expected to see list of dwarves, jobs and skill level. Displays
a blank list.
Control 2: Expected to see list of dwarves, jobs and skill level. Displays
as expected.

What version of the product are you using? On what operating system?
Control 1: v0.28.181.40d11 - Modified raws and Mayday graphic pack (version
DFG18)
Operating System: Windows XP Home Edition (5.1, Build 2600) Service Pack 3
(2600.xpsp_sp3_gdr.090206-1234)

Control 2: v0.28.181.40d - 'Vanilla' (No modifications)
Operating System: See Above

Comments:
Everything works up to the point of loading information from current game.
In Control 1, using my 'default' Dwarf Fortress including raw changes and
graphic pack. Control 2 is everything's that's included in the .zip file
from Bay12 website. No other changes. Using Dwarf Manager (v0.7) has no
issues with either set up.

Also, why does the program need internet access? Didn't see anything about
it so I went ahead and blocked it.

Just a bit of scrap here - this may play in to your datamodel changes, but 
looking ahead I see two things on the UI design
1. Keeping folks to as few screen changes as possible; anchored around the 
labor grid. 
 - I think most will be using the group-by profession OR custom labor tabs 
(but i think still the latter will only supplement the former)
 - Functions to show/hide elements in or next to the labor grid would go a 
very long way to achieving this. What to avoid is making duplicate long-
lists of dwarves to show alternate data.  For example dwarf states only 
need to be checked once in a while so they can be hidden to save real-
estate when [micro]managing labors.
2. Adopting a MFD approach for other game data that is aggregate data or 
not dwarf-centric. Similar to discussions regarding the tabbed labor 
screens, build an element list to choose from that can be added on a given 
panel, even allowing blank customizable panels.
Example:
A Summary Panel might by default look like this:
Total Dwarves:
PODs (Pissed Off Dwarves):
Adult Laborers:
Adult Military:
Children:
Babies: 
Nobles:

but you could pop out a selector and choose which to remove from that 
display, rename it, or add other display fields, like GDI - Gross Dwarf 
Income ...etc.

Would be nice to see at a glance, maybe it's own tab for active military:
- Military Status (on duty/stand down)
- Squad Leader or group by squad leader

Set a nickname for a dorf
click Clear Changes
custom nickname still present. 

Ctrl and Shift controls for multiple dwarf selection for use with 
assigning professions en masse

the app should check at startup for new versions and provide a download link 
when one is available.

States I can think of off the top of my head:
- Happiness
- Current Activity/Job
- Special states? Unconsciouss/Thirsty/Dehydrated
- Wounded / Unwounded (any wound) / Critical wound (any RED wound)

Allow user to set tooltip delay

Understood this is not intended to be functional in this version, just 
noting as a high-priority for release to get profession management 
handling in DT

Change nickname changes are lost when committing changes - looks like this 
is intended in current version as a nick change will not activate the 
commit button.

Summary: Creating a custom profession and disabling the hauling jobs (and
cleaning and burial and so on) don't work. When assigning that custom
profession, the hauling jobs stay enabled. This is visible from both ingame
and the therapist window itself.

What steps will reproduce the problem?

1. Create Custom Profession called Test with no active hauling jobs.
2. Apply Test on a random dwarf.

What version of the product are you using? On what operating system?

0.1.6

I'd love to be able to have a military tab that would allow me to assign 
and group squads and manage their weapons and armor.  It's a royal pain to 
do those things in game.

Thanks for your consideration,

NoSKills

Import custom professions
Edit any profession, notice no labors are selected for any profession.

Would be a nice visual cue to pop slack indicators in the dwarf list. See 
attached mock-up.

fix it.

The little dots per skill level are hard to differentiate, a legend should be 
drawn on some side of the main table, possibly as a docking window so users 
can drag it around, detach it, or close it.

See mockup attached.
Suggested implementation:
Single L-click column header produces highlit header with corresponding 
vertical guides.
Single L-click row header produces same effect on horizontal row selected.
Remove existing guides with escape key (?), single-clicking existing guide 
headers, or other mechanism

Scope option: include multi-select rows and columns with ctrl single L-
click

Load fort and DT. Confirm changes save.
Save DF game. At menu Continue game. 
At this point any commit will hang the app.

Seems straightforward that this workflow would not be supported, would be 
worth it to explore command timeout or check; on fail prompt the user, 
something like that. 

This enhancement request requires no additional detail.
Refer to developer for scope items and functional imperatives.

However these are resolved correctly for removal/adding - see attached 
screen

So something is clearly wrong with my labors getting set from DT.
Not sure exactly why, but i have restored the game at least once, and i'm 
not sure if that would have any bearing - but it's the only thing i know 
that's different now.

Anyway, I set a labor, and save it. It shows in-game as set, however the 
dwarf never acts as though the labor is set. I have followed dwarves 
around and this is very clearly the case - it's not behavior modifier 
driven, because as soon as I unset/reset that same labor in game they 
immediately start working with that new labor.

Also - see screenshot - there are numbers next to the skills now, and that 
looks....weird. Hopefully this is a clue as to why things are fucked up. 

Also attached run.log from this session

With single click enabled, would like ability to choose which mouseclick 
sets the labor. Personally i like poking the screen/focusing with L-click 
without setting the labor, but have single R-click set the labor.

This could be default behavior for single-click setting, or you can make a 
preference for it in the options and let the user decide L left R click on 
single click (or both?)

Create a way for user to easily initialize/default value the profile .ini
You're updating this file on exit which i think is important to keep so 
will somehow have to deal with that. Maybe set a startup bit and when 
feature is used:
Prompt to confirm
Set startup bit
Notify user that next startup default settings will be used

thought - would it be useful to have something like this for purging 
custom professions only? mreh.

Seems a bit silly, frankly, but I suppose some people might want this. 
Just a thought.

Add column to indicate dwarf happyness 
smileyfaces of course.

Design: Maybe move this to part of a "Dwarf State" tab/form that has other 
non-labor data in it ?