seblague / procedural-planets

Procedural-Planets

Simple procedural planet generation in Unity. Watch tutorial series here.

procedural-planets's Issues

Getting an error when trying to change cube/sphere resolution in inspector [EP02]

Error:

`NullReferenceException: Object reference not set to an instance of an object
Planet.GenerateMesh () (at Assets/Planet.cs:66)
Planet.GeneratePlanet () (at Assets/Planet.cs:49)
PlanetEditor.OnInspectorGUI () (at Assets/editor/PlanetEditor.cs:17)
UnityEditor.UIElements.InspectorElement+<CreateIMGUIInspectorFromEditor>c__AnonStorey1.<>m__0 () (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorElement.cs:501)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr) (at C:/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:179)

Relevant code (plus context. I tried to put the line numbers in but it messes with formatting, rip):
Planet.cs:
lines 47-51

    public void GeneratePlanet() {
        Initialize();
        GenerateMesh();
        GenerateColours();
    }

and
lines 64-68

    void GenerateMesh() {
        foreach (TerrainFace face in terrainFaces) {
            face.ConstructMesh();
        }
    }

PlanetEditor.cs:
line 17
planet.GeneratePlanet();

TerrainFace.cs

public void ConstructMesh() {
        Vector3[] vertices = new Vector3[resolution * resolution];
        int[] triangles = new int[(resolution - 1) * (resolution - 1) * 6];
        int triIndex = 0;

        for (int y = 0; y < resolution; y++) {
            for (int x = 0; x < resolution; x++) {
                int i = x + y * resolution;
                Vector2 percent = new Vector2(x, y) / (resolution - 1);
                Vector3 pointOnUnitCube = localUp + (percent.x - .5f) * 2 * axisA + (percent.y - .5f) * 2 * axisB;
                Vector3 pointOnUnitSphere = pointOnUnitCube.normalized;
                vertices[i] = shapeGenerator.CalculatePointOnPlanet(pointOnUnitSphere);

                if (x != resolution - 1 && y != resolution - 1) {
                    triangles[triIndex] = i;
                    triangles[triIndex + 1] = i + resolution + 1;
                    triangles[triIndex + 2] = i + resolution;

                    triangles[triIndex + 3] = i;
                    triangles[triIndex + 4] = i + 1;
                    triangles[triIndex + 5] = i + resolution + 1;
                    triIndex += 6;
                }
            }
        }
        mesh.Clear();
        mesh.vertices = vertices;
        mesh.triangles = triangles;
        mesh.RecalculateNormals();
    }

I'm only at the end of EP02, but I should be able to change the color, radius, and resolution of the sphere in real time. This is the error I get when I try to change the resolution. I haven't even tried to change radius or color yet. This error has persisted in a few forms throughout EP01 and EP02 (I have not once been able to change resolution with the slider in the inspector). I've included my entire assets folder in case you want to check it out for a solution for me. Thanks in advance!
Assets.zip

Incorrect value in Noise.cs

In the noise class for 3d noise, it seems like your code was based off of code that contained a mistake in it. That mistake was later corrected and detailed within a paper on page 13 => https://weber.itn.liu.se/~stegu/simplexnoise/simplexnoise.pdf

your values of 0.6 should be 0.5

This may be why your function sometimes does not return a value between -1 and 1

EP06: Line instead of multiple colors on planet

Visible here:

EP01: NullReferenceException: Object reference not set to an instance of an object Planet.Initialize () (at Assets/Planet.cs:41) Planet.OnValidate () (at Assets/Planet.cs:16)

When the script finishes compiling, it throws this really ugly error:

NullReferenceException: Object reference not set to an instance of an object Planet.Initialize () (at Assets/Planet.cs:41) Planet.OnValidate () (at Assets/Planet.cs:16)

i use unity 2020.2.6f1
How do i fix that ?

Thanks !

ChangeCheckScope error

Ref: E02 - Planet editor
while creatinng the Planet Editor GUI the line:
"using (var check = new EditorGUI.ChangeCheckScope())"
Keeps throwing back the error that the name "ChangeCCheckSCope" doesnt exist in the type "EditorGUI"
My code is identical to the code shown on screen, does anyone know a fix for this?

Update i accidently had an outdated Unity engine installed lmao

Ocean colour on terrain when height is beyond a limit

If the height of terrain is increased too much, it starts picking up ocean colours. Screenshot attached for reference.

licensing issue with noise.cs

I noticed that noise.cs is GPL licensed, but this is an MIT licensed project. I don't think this is allowed under the GPL license.

Fortunately, I found what appears to be a more powerful, MIT licensed alternative inspired by the same library.

https://github.com/Auburns/FastNoise_CSharp

Shader resetting to gray scale on Run or Save

Hey!

I am getting an issue with Unity 2019.x

After generating the planet, the shader works perfectly fine. But, as soon as you save the scene or press Run, the planet goes back to using what seems to be the default material and becomes all grey?

Im attaching the images that show this:

After clicking Generate Planet:

After clicking Save (or pressing CTRL + S):

Any hints of why this is happening?

It doesnt work

The Planet script does not work.

EP05 | Vector4 & PBRGraph

Hello! I'm absolutely having a blast with your tutorial.

I just wanted to point out that with the current version of the lightweight render pipeline I'm getting an error when using a Vector2 property for _elevationMinMax and had to use a Vector4 like in the ColorGenerator.cs script to get the shader to compile right.

Again, so much fun. Keep making awesome stuff!

(Question) Mesh Terrain Faces Dynamic with Planet Resolution

The planet is generated with 6 terrain faces but lets say we wanted to generate a massive sphere and only generate parts of the planet at a time. In order to do this we would need more then 6 meshes, this is where it would be nice to make the terrain faces (meshes) dynamic with the planets resolution.

When I looked at the Planet.cs code, I saw that each terrain face used its own vector.

Procedural-Planets/Procedural Planet E01/Assets/Planet.cs

Line 28 in 6b55142

Vector3[] directions = { Vector3.up, Vector3.down, Vector3.left, Vector3.right, Vector3.forward, Vector3.back };

How could we create more vector directions in this array to account for more terrain faces?

Unity 2020.1 Purple non-lit planet, but no shader errors in the log

Have no idea what is wrong, UniversalRP installed and selected, what might be the problem? Switching between Planet and Planet 1 shaders has no difference.

My planet turns black on play/after play

Hi so this is how my planet looks and this is the message I get after clicking on the material on the planet script.

This is how it normally looks:

After play and clicking on the gradient customizer:

Thanks for any help!