The matchy from sebastiaanspeck

Translate French application.php

Describe the solution you'd like
The French application.php is still using the English translations. Translate it to French.

Additional context
#1

Translate countries

Is your feature request related to a problem? Please describe.
Right now the countries are still in English.

Describe the solution you'd like
A countries.php with the translations of the countries.

TODO

Several bugs for stage/round

Describe the bug

The stage/round wasn't always showed.
Colors were not consistent
Translations for cup_rounds incomplete
Translations for competitions incomplete

Additional context

Translations for cup_rounds will be extended iterative

Penalty-score handling is incomplete

Is your feature request related to a problem? Please describe.

Penalty-score is not always shown properly.
Winning team is not calculated correctly when the match finished after penalties.

Describe the solution you'd like

Penalty-score is not always shown properly:
- Check if penalty-score is in the home-team and local-team data. If not, show just (PEN) instead of ( - ).
Winning team is not calculated correctly when the match finished after penalties:
- If match finished after penalties, look at pen_score and use this to calculate winning team.

Rename id-variables to better variable-names

Is your feature request related to a problem? Please describe.
Codacy

Describe the solution you'd like
Renamed id to fixture_id e.a.

Additional context
There are more Codacy-issues than just the one named here.

Add header to show the matchday/round

Describe the solution you'd like
Right now if you get a lot of matches, you don't see the matchday/round of the matches. I think this will be helpful for readability. So the solution would be to add an header to the tables and with the matchday/round in it.

Additional context
For a example, see here

Rewrite table to grid

Describe the solution you'd like
Right now the blade-files use <table>s to format the data. I think it will be better to rewrite these to grids inside the blade-files.

Additional context
If you need more context, comment on this issue.

Translate injuries

Is your feature request related to a problem? Please describe.
The injuries that are included with the sidelined-players are still in English.

Describe the solution you'd like
I would like to have an injuries.php with the translations of the injuries for each language.

Additional context
Use the injuries.php as starting point and translate the injuries to the language you are translating to.

NOTE
The "knock" injury is something like a small minor injury.
Here I found a forum where they discussed it.

TODO

Improve application-specific language-files

Is your feature request related to a problem? Please describe.
To support multiple-language, I created an English and Dutch language-file. These files can be improved and extend it with new languages.

Describe the solution you'd like
The language-files (called application.php) for English and Dutch are a good start, but I think they can be improved and will eventually improve the localisation of this application.

Describe alternatives you've considered
I made a start to translate all the English labels to Dutch, but I am not yet satisfied with all translations.

Additional context
Add any other context or screenshots about the feature request here.

TODO

Fix unnecessary else-statement in SoccerAPIController.php

Is your feature request related to a problem? Please describe.
Fix unnecessary else-statement

Create artisan command to copy SoccerAPIClient.php

Instead of copying SoccerAPIClient.php manually to the vendor folder, I'm proposing an artisan command that can be called on step 7 of the installation. I can work for the PR if it's OK

Fix top scorers for excluded leagues

Is your feature request related to a problem? Please describe.
Right now the top scorers are not shown for World Cup.
At this moment this is no issue for Champions League and Europa League, but this will become an issue when those tournaments reach knock-out phase

Describe the solution you'd like
Show the top scorers for the World Cup (not only the final but the whole tournament)

Additional context
I think we need to use aggregated endpoint here:
$soccerAPI->topscorers()->setInclude($includeTopscorersAggregated)->aggregatedBySeasonId($league->current_season_id)->aggregatedGoalscorers->data;

No such method exists: deviceType

As soon as I browse the URL, this shows up. And nothing seems to be working :(

README Update

The README file looked like it has floating parenthesis and made it harder to digest. Someone should definitely enter their API key in the .env and not any other file.

Avoid variables with short names like $d. Configured minimum length is 3.

Fix Codacy-issue

Add top scorers

Is your feature request related to a problem? Please describe.
I want to show the top-10 top scorers for all leagues.

Describe the solution you'd like
Some leagues don't have topscorers-coverage (mostly cups), to determine this, you can view it using
$league->coverage->topscorer_goals and if it returns false, there is no topscorers-coverage

Some leagues are cups, but do have topscorers-coverage (like Champions League). For these leagues I only want the topscorers for the group-stage and the knock-out afterwards, so exclude the qualifying topscorers.

Some leagues are no cups and do have topscorers-coverage (mostly competitions like Premier League). For those leagues I only want the topscorers from the Regular Season-stage.

Look in the API-docs for more information about the endpoints. If you want to use the aggregatedTopscorers, copy the folder to vendor/kirill-latish.

Test your solution with the next leagues:

Pro League or Eredivisie
Premier League
FA Cup (or any other cup) -> this one doesn't need to show any top scorers
World Cup -> show the aggregated top scorers
Champions League/Europa League -> show the aggregated top scorers, but leave out the top scorers from the qualifications-rounds

Preferably I don't want to have hardcoded the leagues that use specific cases. I want a dynamic solution, so that if we add more leagues later on, this issue doesn't reappears.

Describe alternatives you've considered
#36 #46

We tried several things, but the ultimate solution hasn't been found yet.

Additional context

I contacted the API-supplier for a solution, but I am still awaiting their reaction.
If you want to take this issue, comment with your email, I will create and send you an API-token to test your solution.