seawatts / ember-cli-commands

This ember addon is aimed to solve mundane tasks in ember-cli.

Hi there 👋

I'm @seawatts, Founder and CTO at Shuffl

• 🧑‍💻 Here are some of my ideas
• 👯 I’m looking to collaborate on anything Crypto
• 💬 Ask me about Sailing
• 😄 Pronouns: He / Him
• ⚡ Fun fact: My dogs name is Bisou 🇫🇷
• 📦 Ex-Amazon building drones 🤖 ✈️

A list of tech that I enjoy working with.

Backend

• AWS
  • Lambda - Node.js Typescript (Serverless Event processing / GraphQL resolvers)
  • DynamoDB (Data storage)
  • AppSync (GraphQL API)
  • IoT Core / Greengrass
  • S3 (Storage)
  • ECS (Container Orchestration)
  • AWS CDK (Cloudformation)
  • AWS CodePipeline (CI/CD)
• Code
  • Typescript
  • TypeDI - Typescript Dependency Injection
  • Jest (Test framework)
• Docker

Front end tech

• Next.js
• React / React Native - Typescript
• Netlify (Website hosting)
• GraphQL (API)
  • Apollo Client
  • GraphQL Subscriptions
• Tailwind CSS
• Testing
  • Storybook (UI Design Testing)
  • Playwright (Integration Testing)
  • Jest (Unit Testing)

ember-cli-commands's Issues

should --yarn be the default?

I can see strong argument for either case. But --npm might be the more logical optional choice.

Will have to look at what ember cli does.

Maybe commentary from the cli core team. Want to get v1.0.0 right out the gate. Because switching this later is a breaking change I think.

Log to UI when fetching ember-new-output

https://github.com/seawatts/ember-cli-commands/blob/develop/lib/utils/fetch-ember-new-output.js#L4

It might be a good idea to log or console out this to UI. For two reasons

1.) Makes it obvious to the user what happens behind the scenes. Show the exact URL fetched so user can look at it themselves.
2.) If a network issue or some janky network connection causes problems it is clear what was attempted but failed. Although I see you have a catch inside the fetchJSON promise that does a console.log so that might be sufficient.

Error: Cannot find module 'package-json'

Trying to install inside an addon and I get the following error when install via ember command

› node -v
v6.7.0

› ember install ember-cli-commands
NPM: Installed ember-cli-commands
Cannot find module 'package-json'
Error: Cannot find module 'package-json'
    at Function.Module._resolveFilename (module.js:455:15)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (...snip snip ... /node_modules/ember-cli-commands/lib/utils/get-ember-cli-tags.js:1:83)
    at Module._compile (module.js:556:32)

feature idea: use externally of project

We should consider the use case of using this without being installed inside a local ember project or addon.

imagine it being installed globally and then upgrade the deps of any project on your computer.

I suggest we create a separate command for this.

ember upgrade-project --path=path/to/my/app

It could probably share some of the other commands and flags.

The use case is I may have numerous small projects on my computer and I just want to install this once to run it. Plus I may have reasons for not including as a dependency on all my projects, particularly if I want a really light weight project, or CI reasons for keeping the dep tree as minimal as possible. Plus it is one more thing to keep updated if I have it installed in many different projects.